You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/01 19:52:38 UTC
Re: Review Request 70900: Updated an equality operator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70900/
-----------------------------------------------------------
(Updated July 1, 2019, 7:52 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description (updated)
-------
This patch updates the equality operator for the `Task`
message to include two missing conditions. An equality
operator for `HealthCheck` is also added to make this
possible.
Diffs (updated)
-----
include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
src/common/type_utils.cpp a7eb0e922c5d6d095410b058955088dfafba3aa9
Diff: https://reviews.apache.org/r/70900/diff/2/
Changes: https://reviews.apache.org/r/70900/diff/1-2/
Testing
-------
Testing details at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 70900: Updated an equality operator.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70900/#review216324
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 1, 2019, 12:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70900/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 12:52 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the equality operator for the `Task`
> message to include two missing conditions. An equality
> operator for `HealthCheck` is also added to make this
> possible.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d
> src/common/type_utils.cpp a7eb0e922c5d6d095410b058955088dfafba3aa9
>
>
> Diff: https://reviews.apache.org/r/70900/diff/2/
>
>
> Testing
> -------
>
> Testing details at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>