You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/08 14:30:06 UTC
[jira] [Commented] (ARTEMIS-1590) Use properties to configure JDBC
store SQLProvider
[ https://issues.apache.org/jira/browse/ARTEMIS-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316403#comment-16316403 ]
ASF GitHub Bot commented on ARTEMIS-1590:
-----------------------------------------
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1756
[ARTEMIS-1590] Properties-based SQLProvider
Replace GenericSQLProvider and other implementation by a single
PropertySQLProvider that uses properties to define SQL queries.
SQL queries are loaded from the journal-sql.properties file.
Queries specific to a DB dialect can be specified by adding a suffix to
the key of the generic property.
For example, the generic property to create a file Table is:
```
create-file-table = CREATE TABLE %s (ID BIGINT AUTO_INCREMENT, ...)
```
This property can be customized for Derby by using the
`create-file-table.derby` property:
```
create-file-table.derby=CREATE TABLE %s (ID BIGINT NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1),...
```
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1590
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-1590_JDBC_PropertySQLProvider
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1756.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1756
----
commit 69e352015f5e33bc833976acea7e2edabafe1273
Author: Jeff Mesnil <jm...@...>
Date: 2018-01-05T10:54:48Z
[ARTEMIS-1590] Properties-based SQLProvider
Replace GenericSQLProvider and other implementation by a single
PropertySQLProvider that uses properties to define SQL queries.
SQL queries are loaded from the journal-sql.properties file.
Queries specific to a DB dialect can be specified by adding a suffix to
the key of the generic property.
For example, the generic property to create a file Table is:
create-file-table = CREATE TABLE %s (ID BIGINT AUTO_INCREMENT, ...)
This property can be customized for Derby by using the
create-file-table.derby property:
create-file-table.derby=CREATE TABLE %s (ID BIGINT NOT NULL GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1),...
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1590
----
> Use properties to configure JDBC store SQLProvider
> --------------------------------------------------
>
> Key: ARTEMIS-1590
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1590
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Jeff Mesnil
>
> This follow up the conversation started on activemq-dev mailing list[1] to use a properties-based implementation for Artemis SQLProvider to ease maintenance and support of different databases and their dialects.
> [1] http://mail-archives.apache.org/mod_mbox/activemq-dev/201711.mbox/%3cCAAEH2wf_aJyvZfagLczFwpDMcWLpyDsRNio_4+k+MThdZphC6Q@mail.gmail.com%3e
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)