[GitHub] [incubator-nemo] hy00nc edited a comment on issue #222: [NEMO-350] Implement Off-heap SerializedMemoryStore & [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore

[GitBox <gi...@apache.org>]

hy00nc edited a comment on issue #222: [NEMO-350] Implement Off-heap SerializedMemoryStore & [NEMO-384] Implement DirectByteBufferInputStream for Off-heap SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/222#issuecomment-503445678
 
 
   > Thanks @hy00nc! I've left some comments. I also have two questions regarding the issue description.
   > 
   > First, I was not able to find in the code "If there is any chance of using getData() in SerializedPartition, we check the length of the SerializedData to ensure that this SerializedPartition was created from existing data". Can you point me to it?
   > 
   > Second, can you file a JIRA issue and add a TODO comment besides `allocateDirect`? That would make it clear that line of code causes overheads.
   > 
   > e.g.,
   > // TODO #999: ISSUE_TITLE
   
   Thanks for the review @johnyangk !
   
   For the first question, I didn't update the comment after addressing some fixes for the bug. Sorry for the confusion. Please check the updated comment :)
   
   For the second one, maybe I can add to the existing [JIRA](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-388) about the overhead. I will also add the TODO in the code, thanks!
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services