You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/07 23:04:30 UTC
[GitHub] [airflow] gmcrocetti opened a new pull request, #24308: Fix: AwsGlueJobOperator - patches #24215
gmcrocetti opened a new pull request, #24308:
URL: https://github.com/apache/airflow/pull/24308
Previous solution (#24215) didn't solve the issue mentioned in [here](https://github.com/apache/airflow/issues/20832#issuecomment-1011502821).
This error was raised thanks to tests performed for https://github.com/apache/airflow/issues/24289.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24308: Fix: AwsGlueJobOperator - patches #24215
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24308:
URL: https://github.com/apache/airflow/pull/24308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #24308: Fix: AwsGlueJobOperator - patches #24215
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #24308:
URL: https://github.com/apache/airflow/pull/24308#issuecomment-1149613534
Not related to this PR just my 50 cents about design Glue operator / Hook
IMHO, better to do refactor them in near future rather than try to add new features / bug fixes
At that moment `GlueJobOperator` do up to three different things and could be split to different operators
1. (optional) Upload local file to S3 (same as `LocalFilesystemToS3Operator`)
1. (optional) Create Job and don't update on changes `¯\_(ツ)_/¯`
1. Run Glue Job
And GlueJobHook only design to use only for this single operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org