[jira] [Comment Edited] (THRIFT-4907) C# code signing not working

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882519#comment-16882519 ] 

Jens Geyer edited comment on THRIFT-4907 at 7/11/19 12:27 AM:
--------------------------------------------------------------

> Looking at the DLL, it's not signed at all.

I looked and all three DLLs in the package are signed. What am I doing wrong?

EDIT: I guess I know what the actual issue really is. The strong name cannot be applied afterwards, unless there is space reserved at build time. That was not the case when the 0.12.0 binaries were built, hence although we can give you digitally signed DLLs, we cannot add the strong name to 0.12.0 binaries without doing a full release cycle.



was (Author: jensg):
> Looking at the DLL, it's not signed at all.

I looked and all three DLLs in the package are signed. What am I doing wrong?

> C# code signing not working
> ---------------------------
>
>                 Key: THRIFT-4907
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4907
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, C# - Library, netcore - Library
>    Affects Versions: 0.12.0
>            Reporter: Benjamin Kraemer
>            Assignee: Jens Geyer
>            Priority: Blocker
>             Fix For: 0.13.0
>
>
> In THRIFT-2947, a strong name should have been added to [https://www.nuget.org/packages/ApacheThrift/0.12.0.1]
> Looking at the DLL, it's not signed at all. The assembly name is still `Thrift, Version=0.12.0.0, Culture=neutral, PublicKeyToken=null` and therefore missing the `PublicKeyToken` part.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)