You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2017/08/10 12:27:57 UTC

[GitHub] drill pull request #902: DRILL-5714: Fix NPE when mapr-db plugin is used in ...

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/902

    DRILL-5714: Fix NPE when mapr-db plugin is used in table function

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5714

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/902.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #902
    
----
commit bdfb4ab29ae735b125f58a02c6302fbe43da31a7
Author: Arina Ielchiieva <ar...@gmail.com>
Date:   2017-08-10T11:34:13Z

    DRILL-5714: Fix NPE when mapr-db plugin is used in table function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #902: DRILL-5714: Fix NPE when mapr-db plugin is used in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/902


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #902: DRILL-5714: Fix NPE when mapr-db plugin is used in table f...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/902
  
    @paul-rogers, thansk for the code review. 
    
    Here is short description, hope it would be helpful:
    The main change is in `MapRDBSubScan` class. The problem was that mapr-db plugin was trying to get format plugin from the default list of format plugins (which is created at Drill start up) but since table function uses custom format it was getting null value. For this case we need to get format plugin from `StoragePluginRegistry` which will create format plugin if it is absent in the list of default ones. For example, the same approach is used in `EasySubScan` class which is used for text plugin.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #902: DRILL-5714: Fix NPE when mapr-db plugin is used in table f...

Posted by paul-rogers <gi...@git.apache.org>.

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/902
  
    Thanks for the explanation. Looks good.
    +1 (again)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---