You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2026/03/31 07:14:04 UTC
(tika) 01/01: [TIKA-4704] use TemporaryResources to avoid leak
This is an automated email from the ASF dual-hosted git repository.
tilman pushed a commit to branch TIKA-4704-4
in repository https://gitbox.apache.org/repos/asf/tika.git
commit 6d35e58eed3a0c51b96b355a3dba86f9fa541b27
Author: Tilman Hausherr <ti...@snafu.de>
AuthorDate: Tue Mar 31 09:13:55 2026 +0200
[TIKA-4704] use TemporaryResources to avoid leak
Added temporary resources management for TikaInputStream.
---
.../org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java
index 005e036099..edcfc61e6f 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/OOXMLExtractorFactory.java
@@ -97,11 +97,12 @@ public class OOXMLExtractorFactory {
//if the pkg is in the opencontainer of a TikaInputStream, it will get closed.
//However, if a regular inputstream has been sent in, we need to revert the pkg.
boolean mustRevertPackage = false;
+ TemporaryResources tmp = new TemporaryResources();
try {
OOXMLExtractor extractor = null;
// Locate or Open the OPCPackage for the file
- TikaInputStream tis = TikaInputStream.get(stream);
+ TikaInputStream tis = TikaInputStream.get(stream, tmp, metadata);
if (tis.getOpenContainer() instanceof OPCPackageWrapper) {
pkg = ((OPCPackageWrapper) tis.getOpenContainer()).getOPCPackage();
} else {
@@ -226,6 +227,7 @@ public class OOXMLExtractorFactory {
tmpRepairedCopy.getAbsolutePath());
}
}
+ tmp.dispose();
}
}