[GitHub] [camel] omarsmak commented on a change in pull request #5337: "CAMEL-16481:camel-vertx-kafka set custom timestamp"

[GitBox <gi...@apache.org>]

omarsmak commented on a change in pull request #5337:
URL: https://github.com/apache/camel/pull/5337#discussion_r611409725



##########
File path: components/camel-vertx-kafka/camel-vertx-kafka-component/src/main/java/org/apache/camel/component/vertx/kafka/operations/VertxKafkaProducerOperations.java
##########
@@ -189,4 +190,17 @@ private Object getMessageValue(final Message message, final Object inputData) {
         return VertxKafkaTypeSerializer.tryConvertToSerializedType(message, inputData,
                 configurationOptionsProxy.getValueSerializer(message));
     }
+
+    private Long getOverrideTimestamp(final Message message) {
+
+        Object timeStamp = configurationOptionsProxy.getOverrideTimestamp(message);
+        Long overrideTimestamp = 0L;

Review comment:
       in case if no `OVERRIDE_TIMESTAMP` being set, does it make sense to initialize it with `null` instead of `0L`? For me 0L is manipulating the timestamp in case there is no a timestamp being set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org