[jira] [Commented] (YARN-2924) Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240347#comment-14240347 ] 

Hadoop QA commented on YARN-2924:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12685152/YARN-2924.1.patch
  against trunk revision 03867eb.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 10 new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6062//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6062//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-client.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6062//console

This message is automatically generated.

> Node to labels mapping should not transfer to lowercase when adding from RMAdminCLI
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-2924
>                 URL: https://issues.apache.org/jira/browse/YARN-2924
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2924.1.patch
>
>
> In existing implementation, when parsing node-to-labels mapping from RMAdminCLI, it transferred all labels to lowercase:
> {code}
>       for (int i = 1; i < splits.length; i++) {
>         if (!splits[i].trim().isEmpty()) {
>           map.get(nodeId).add(splits[i].trim().toLowerCase());
>         }
>       }
> {code}
> That is not correct, we should fix that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)