You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/16 16:41:32 UTC
[GitHub] mistercrunch commented on a change in pull request #6700: Bump some
of the requirements-dev.txt
mistercrunch commented on a change in pull request #6700: Bump some of the requirements-dev.txt
URL: https://github.com/apache/incubator-superset/pull/6700#discussion_r248359286
##########
File path: superset/models/user_attributes.py
##########
@@ -15,8 +15,9 @@
# specific language governing permissions and limitations
# under the License.
from flask_appbuilder import Model
-from sqlalchemy import Column, ForeignKey, Integer
-from sqlalchemy.orm import relationship
+from sqlalchemy import Column, ForeignKey, Integer # pylint: disable=wrong-import-order
Review comment:
Oh yeah, not sure what this was about, wrote the PR months ago. I ended up backtracking on `pylint` since 2.x+ is much slower for some reason, removing these edits...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org