You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/07/02 08:48:49 UTC
Review Request 12227: NPE wile deployVM in kvm due to capacityIops
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/
-----------------------------------------------------------
Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
Bugs: 3301
Repository: cloudstack-git
Description
-------
Issue:
When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
Fixed:
SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
This fixed will resolve the issue for any storage provider which don't set capacityIops.
Diffs
-----
server/src/com/cloud/storage/StorageManagerImpl.java 8401b77
Diff: https://reviews.apache.org/r/12227/diff/
Testing
-------
1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
Thanks,
Rajesh Battala
Re: Review Request 12227: NPE wile deployVM in kvm due to capacityIops
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22666
-----------------------------------------------------------
Rajesh,
Can you re-upload patch again.
Diff is showing following error.
-----
Diff revision 1 (Latest)
Files Changed:
server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently unavailable.
- Sateesh Chodapuneedi
On July 2, 2013, 6:48 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 8401b77
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
RE: Review Request 12227: NPE wile deployVM in kvm due to
capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
Hi Sateesh,
For this patch https://reviews.apache.org/r/12158/ it is dependent on https://reviews.apache.org/r/11992/ . It is already committed by Edison in 4.2 only.
Thanks
Rajesh Battala
> -----Original Message-----
> From: Rajesh Battala [mailto:rajesh.battala@citrix.com]
> Sent: Tuesday, July 2, 2013 8:55 PM
> To: Sateesh Chodapuneedi; Ram Ganesh; Edison Su
> Cc: cloudstack
> Subject: RE: Review Request 12227: NPE wile deployVM in kvm due to
> capacityIops
>
> The issue is that, this patch is dependent on the review
> https://reviews.apache.org/r/12158/ .
> I had kept that dependency while creating the review request.
> First this patch should be committed https://reviews.apache.org/r/12158/
> and then the current patch.
>
> Thanks
> Rajesh Battala
>
> From: Sateesh Chodapuneedi [mailto:noreply@reviews.apache.org] On
> Behalf Of Sateesh Chodapuneedi
> Sent: Tuesday, July 2, 2013 8:49 PM
> To: Ram Ganesh; Sateesh Chodapuneedi; Edison Su
> Cc: Rajesh Battala; cloudstack
> Subject: Re: Review Request 12227: NPE wile deployVM in kvm due to
> capacityIops
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
>
>
>
>
> Rajesh,
>
> Can you re-upload patch again.
>
> Diff is showing following error.
>
> -----
>
> Diff revision 1 (Latest)
>
> Files Changed:
>
> server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently
> unavailable.
>
>
>
>
> - Sateesh Chodapuneedi
>
>
> On July 2nd, 2013, 6:48 a.m. UTC, Rajesh Battala wrote:
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh
> Chodapuneedi.
> By Rajesh Battala.
>
> Updated July 2, 2013, 6:48 a.m.
> Bugs: 3301
> Repository: cloudstack-git
> Description
>
> Issue:
>
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
>
>
> Fixed:
>
> SolidFire storage had introduced iops, its setting capacityIops on the pool
> level. Only solidfire is setting and getting it which is causing NPE when
> checking this value for other type PS.
>
> This fixed will resolve the issue for any storage provider which don't set
> capacityIops.
>
>
> Testing
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
>
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Diffs
>
> * server/src/com/cloud/storage/StorageManagerImpl.java (8401b77)
>
> View Diff<https://reviews.apache.org/r/12227/diff/>
>
RE: Review Request 12227: NPE wile deployVM in kvm due to
capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
The issue is that, this patch is dependent on the review https://reviews.apache.org/r/12158/ .
I had kept that dependency while creating the review request.
First this patch should be committed https://reviews.apache.org/r/12158/ and then the current patch.
Thanks
Rajesh Battala
From: Sateesh Chodapuneedi [mailto:noreply@reviews.apache.org] On Behalf Of Sateesh Chodapuneedi
Sent: Tuesday, July 2, 2013 8:49 PM
To: Ram Ganesh; Sateesh Chodapuneedi; Edison Su
Cc: Rajesh Battala; cloudstack
Subject: Re: Review Request 12227: NPE wile deployVM in kvm due to capacityIops
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12227/
Rajesh,
Can you re-upload patch again.
Diff is showing following error.
-----
Diff revision 1 (Latest)
Files Changed:
server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently unavailable.
- Sateesh Chodapuneedi
On July 2nd, 2013, 6:48 a.m. UTC, Rajesh Battala wrote:
Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
By Rajesh Battala.
Updated July 2, 2013, 6:48 a.m.
Bugs: 3301
Repository: cloudstack-git
Description
Issue:
When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
Fixed:
SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
This fixed will resolve the issue for any storage provider which don't set capacityIops.
Testing
1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
Diffs
* server/src/com/cloud/storage/StorageManagerImpl.java (8401b77)
View Diff<https://reviews.apache.org/r/12227/diff/>
Re: Review Request 12227: NPE wile deployVM in kvm due to capacityIops
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22665
-----------------------------------------------------------
Rajesh,
Can you re-upload patch again.
Diff is showing following error.
-----
Diff revision 1 (Latest)
Files Changed:
server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently unavailable.
- Sateesh Chodapuneedi
On July 2, 2013, 6:48 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:48 a.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java 8401b77
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
> On July 8, 2013, 7:16 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Fix looks good.
Thanks for the review comments
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22846
-----------------------------------------------------------
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22846
-----------------------------------------------------------
Ship it!
Fix looks good.
- Venkata Siva Vijayendra Bhamidipati
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
> On July 10, 2013, 9:57 p.m., edison su wrote:
> > Ship It!
Thanks Edison for the review and pushing the patch
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22981
-----------------------------------------------------------
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22981
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/
-----------------------------------------------------------
(Updated July 4, 2013, 12:32 p.m.)
Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
Changes
-------
uploaded the patch rebasing with 4.2 branch.
Summary (updated)
-----------------
NPE while deploying any instances in kvm/vmware using ZWPS due to capacityIops
Bugs: 3301
Repository: cloudstack-git
Description
-------
Issue:
When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
Fixed:
SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
This fixed will resolve the issue for any storage provider which don't set capacityIops.
Diffs (updated)
-----
server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
Diff: https://reviews.apache.org/r/12227/diff/
Testing
-------
1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
Thanks,
Rajesh Battala