[GitHub] [hudi] jonvex commented on a diff in pull request #8789: [HUDI-4932] Add partition inference config

["jonvex (via GitHub)" <gi...@apache.org>]

jonvex commented on code in PR #8789:
URL: https://github.com/apache/hudi/pull/8789#discussion_r1204787670


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/HoodieMergeHelper.java:
##########
@@ -122,12 +121,10 @@ public void runMerge(HoodieTable<?, ?, ?, ?> table,
             baseFileReader,
             HoodieFileReaderFactory.getReaderFactory(recordType).getFileReader(bootstrapFileConfig, bootstrapFilePath),
             mergeHandle.getPartitionFields(),
-            mergeHandle.getPartitionValues());
+            mergeHandle.getPartitionValues(),
+            table.getConfig().isBootstrapPartitionColumnTypeInferenceEnabled());
         recordSchema = mergeHandle.getWriterSchemaWithMetaFields();
-        recordIterator = new ClosableMergingIterator<>(
-            baseFileRecordIterator,
-            (ClosableIterator<HoodieRecord>) bootstrapFileReader.getRecordIterator(recordSchema),
-            (left, right) -> left.joinWith(right, recordSchema));
+        recordIterator = (ClosableIterator<HoodieRecord>) bootstrapFileReader.getRecordIterator(recordSchema);

Review Comment:
   Not sure why the closableMergingIterator was still being used. We already do the merging once



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org