[GitHub] [couchdb-ibrowse] jaydoane commented on a change in pull request #2: Get a new lb pid if existing pid is not alive

[GitBox <gi...@apache.org>]

jaydoane commented on a change in pull request #2: Get a new lb pid if existing pid is not alive
URL: https://github.com/apache/couchdb-ibrowse/pull/2#discussion_r273342725
 
 

 ##########
 File path: src/ibrowse.erl
 ##########
 @@ -335,6 +330,20 @@ send_req(Url, Headers, Method, Body, Options, Timeout) ->
             {error, {url_parsing_failed, Err}}
     end.
 
+lb_pid(Host, Port, Url) ->
+    case ets:lookup(ibrowse_lb, {Host, Port}) of
+        [] ->
+            get_lb_pid(Url);
+        [#lb_pid{pid = Lb_pid_1}] ->
 
 Review comment:
   Ah, good point! I just copied that code block without thinking about simplification. I have updated the PR renaming `Lb_pid_1` to simply `Pid`. Thanks for the eagle eye. I'll update the upstream PR as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services