You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/07/05 06:25:45 UTC

[GitHub] [ignite-3] zstan commented on a diff in pull request #912: IGNITE-17219 Revise types support in schema module

zstan commented on code in PR #912:
URL: https://github.com/apache/ignite-3/pull/912#discussion_r913426272


##########
modules/schema/src/test/java/org/apache/ignite/internal/schema/ColumnDefinitionTest.java:
##########
@@ -43,6 +43,7 @@ public void compareColumns() {
                 new Column("A", DATE, false),
                 new Column("AD", STRING, false),
                 new Column("AA", STRING, false),
+                new Column(-100, "J", STRING, false)

Review Comment:
   I have some questions about Columns.COLUMN_COMPARATOR, thus this change will help some one who have such a questions too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org