[GitHub] [airflow] mik-laj commented on a change in pull request #6536: [AIRFLOW-5885] List of tests is generated dynamically when you enter Breeze

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #6536: [AIRFLOW-5885] List of tests is generated dynamically when you enter Breeze
URL: https://github.com/apache/airflow/pull/6536#discussion_r345166745
 
 

 ##########
 File path: scripts/ci/in_container/run_extract_tests.sh
 ##########
 @@ -16,24 +16,27 @@
 # specific language governing permissions and limitations
 # under the License.
 
+#
 # Bash sanity settings (error on exit, complain for undefined vars, error when pipe fails)
-set -euxo pipefail
+set -euo pipefail
+
+MY_DIR=$(cd "$(dirname "$0")" || exit 1; pwd)
+
+# shellcheck source=scripts/ci/in_container/_in_container_utils.sh
+. "${MY_DIR}/_in_container_utils.sh"
 
-MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" || exit 1; pwd )"
+in_container_basic_sanity_check
 
-AIRFLOW_SOURCES=$(cd "${MY_DIR}/../../.." || exit 1; pwd)
-export AIRFLOW_SOURCES
+in_container_script_start
 
-gosu "${AIRFLOW_USER}" nosetests --collect-only --with-xunit --xunit-file="${HOME}/all_tests.xml"
+TMP_FILE=$(mktemp)
 
-gosu "${AIRFLOW_USER}" \
-    python "${AIRFLOW_SOURCES}/tests/test_utils/get_all_tests.py" \
-                    "${HOME}/all_tests.xml" >"${HOME}/all_tests.txt"; \
+nosetests --collect-only --with-xunit --xunit-file="${TMP_FILE}"
 
-echo ". ${HOME}/.bash_completion" >> "${HOME}/.bashrc"
+export AIRFLOW_ALL_TESTS="${HOME}/all_tests.txt"
 
-chmod +x "${HOME}/run-tests-complete"
+<"${AIRFLOW_SOURCES}/license-templates/LICENSE.txt" sed 's/^/# /' | sed 's/# $/#/'  > "${AIRFLOW_ALL_TESTS}"
 
 Review comment:
   Do we need a license in this file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services