You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/23 00:52:04 UTC
[jira] [Commented] (BEAM-2344) Re-rename fat jar in archetypes
[ https://issues.apache.org/jira/browse/BEAM-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020486#comment-16020486 ]
ASF GitHub Bot commented on BEAM-2344:
--------------------------------------
GitHub user jasonkuster opened a pull request:
https://github.com/apache/beam/pull/3204
[BEAM-2344] Re-rename fat jar
Signed-off-by: Jason Kuster <ja...@google.com>
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`.
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasonkuster/beam jar-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3204
----
commit 94cdd31e1e9a386dfcc7964aecf14ffc1c4f5850
Author: Jason Kuster <ja...@google.com>
Date: 2017-05-23T00:46:49Z
Re-rename fat jar so that install doesn't install the bundled jar as the default jar.
Signed-off-by: Jason Kuster <ja...@google.com>
----
> Re-rename fat jar in archetypes
> -------------------------------
>
> Key: BEAM-2344
> URL: https://issues.apache.org/jira/browse/BEAM-2344
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Jason Kuster
> Assignee: Jason Kuster
> Fix For: 2.1.0
>
>
> Currently fat jar in archetypes will overwrite the standard jar, and will thus be installed as that module's artifact during the install phase. Re-rename it such that it is not.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)