You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ok2c (via GitHub)" <gi...@apache.org> on 2023/09/01 09:29:04 UTC
[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #424: HTTPCORE-756 - Implement RFC9110 Content-Type Validation for OPTIONS Requests
ok2c commented on code in PR #424:
URL: https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312801174
##########
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##########
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, final EntityDetails entity, final
}
}
+ /**
+ * Validates the presence and format of the Content-Type header for an OPTIONS request.
+ *
+ * <p>
+ * According to the HTTP protocol, an {@link Method#OPTIONS} request that contains content must also have
Review Comment:
@reschke What you are saying makes no sense. @arturobernalg We cannot truly know what if `content-type` value is valid or not unless we maintain a list of vales we consider valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org