You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/07/18 09:54:51 UTC

[GitHub] [echarts] AmosChenYQ opened a new pull request #15376: add rotate arg to fix text position bugs in symbol rotate

AmosChenYQ opened a new pull request #15376:
URL: https://github.com/apache/echarts/pull/15376


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Add a rotate argument in createSymbol function to fix text position bugs in symbol rotate
   
   ### Fixed issues
   
   https://github.com/apache/echarts/issues/14718
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   Text position is not in right place when Pin Symbol rotates
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   As shown in issues
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   Add a rotate argument to fix that. Calculate offset by rectangle's width and height instead of simply adding a fixed number.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   ![image](https://user-images.githubusercontent.com/31386769/126062818-b7495ee3-6326-494b-b3f3-1ed1c03f485c.png)
   ![image](https://user-images.githubusercontent.com/31386769/126062835-30233542-9ed5-44d4-a932-c3d2d12bc7ea.png)
   ![image](https://user-images.githubusercontent.com/31386769/126062876-35f7ddf3-b66f-46ea-a235-3f808b063bd8.png)
   
   
   ## Misc
   
   <!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
   
   - [ ] The API has been changed (apache/echarts-doc#xxx).
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15376: add rotate arg to fix text position bugs in symbol rotate

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15376:
URL: https://github.com/apache/echarts/pull/15376#issuecomment-882031162


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org