You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alexis Midon (JIRA)" <ji...@apache.org> on 2008/12/10 01:32:44 UTC
[jira] Created: (BUILDR-223) Release Task: customizable commit
message
Release Task: customizable commit message
-----------------------------------------
Key: BUILDR-223
URL: https://issues.apache.org/jira/browse/BUILDR-223
Project: Buildr
Issue Type: New Feature
Components: Core features
Reporter: Alexis Midon
>From a request on nuildr-dev mailing list:
Next, our commit messages have a special format (we start with keywords), and we cannot use the buildr release without modifications.
I can patch the Release class in my buildfile, but perhaps something similar to the release attribute in buildr 1.3.3 would be possible, like in the
following exemple ?
Release.tag_name = lambda { |ver| "foo-#{ver}" }
Release.commit_format = lambda { |msg| "ADD: #{msg}" }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-223) Release Task: customizable commit
message
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-223.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.4
Patch applied. Many thanks!
boisvert@sixtine:~/svn/buildr-222$ svn commit
Sending CHANGELOG
Sending lib/buildr/core/build.rb
Sending spec/core/build_spec.rb
Transmitting file data ...
Committed revision 749429.
> Release Task: customizable commit message
> -----------------------------------------
>
> Key: BUILDR-223
> URL: https://issues.apache.org/jira/browse/BUILDR-223
> Project: Buildr
> Issue Type: New Feature
> Components: Core features
> Reporter: Alexis Midon
> Fix For: 1.3.4
>
>
> From a request on nuildr-dev mailing list:
> Next, our commit messages have a special format (we start with keywords), and we cannot use the buildr release without modifications.
> I can patch the Release class in my buildfile, but perhaps something similar to the release attribute in buildr 1.3.3 would be possible, like in the
> following exemple ?
> Release.tag_name = lambda { |ver| "foo-#{ver}" }
> Release.commit_format = lambda { |msg| "ADD: #{msg}" }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-223) Release Task: customizable commit
message
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon updated BUILDR-223:
--------------------------------
Attachment: buildr-223.patch.txt
I just noticed that the methods commit_message and tag_name do not work as advertised.
Actually these methods are currently defined as instance methods not class methods.
So Release.tag_name= "" fails. The workaround is to used Release.find.tag_name = ""
Anyway, here is a patch to fix this. Specs are adjusted as well.
The fix removes the instance methods, you might want to keep them around and make them fail with a clear explanation or print a deprecated message.
> Release Task: customizable commit message
> -----------------------------------------
>
> Key: BUILDR-223
> URL: https://issues.apache.org/jira/browse/BUILDR-223
> Project: Buildr
> Issue Type: New Feature
> Components: Core features
> Reporter: Alexis Midon
> Fix For: 1.3.4
>
> Attachments: buildr-223.patch.txt
>
>
> From a request on nuildr-dev mailing list:
> Next, our commit messages have a special format (we start with keywords), and we cannot use the buildr release without modifications.
> I can patch the Release class in my buildfile, but perhaps something similar to the release attribute in buildr 1.3.3 would be possible, like in the
> following exemple ?
> Release.tag_name = lambda { |ver| "foo-#{ver}" }
> Release.commit_format = lambda { |msg| "ADD: #{msg}" }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (BUILDR-223) Release Task: customizable commit
message
Posted by "Alexis Midon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexis Midon reopened BUILDR-223:
---------------------------------
Buildr aborted!
undefined method `commit_message=' for Buildr::Release:Class
> Release Task: customizable commit message
> -----------------------------------------
>
> Key: BUILDR-223
> URL: https://issues.apache.org/jira/browse/BUILDR-223
> Project: Buildr
> Issue Type: New Feature
> Components: Core features
> Reporter: Alexis Midon
> Fix For: 1.3.4
>
>
> From a request on nuildr-dev mailing list:
> Next, our commit messages have a special format (we start with keywords), and we cannot use the buildr release without modifications.
> I can patch the Release class in my buildfile, but perhaps something similar to the release attribute in buildr 1.3.3 would be possible, like in the
> following exemple ?
> Release.tag_name = lambda { |ver| "foo-#{ver}" }
> Release.commit_format = lambda { |msg| "ADD: #{msg}" }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-223) Release Task: customizable commit
message
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-223.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.4)
1.4
Updated patch applied.
------------------------------------------------------------------------
r836108 | boisvert | 2009-11-13 19:07:35 -0800 (Fri, 13 Nov 2009) | 2 lines
BUILDR-223 Release Task: customizable commit message (Alexis Midon)
> Release Task: customizable commit message
> -----------------------------------------
>
> Key: BUILDR-223
> URL: https://issues.apache.org/jira/browse/BUILDR-223
> Project: Buildr
> Issue Type: New Feature
> Components: Core features
> Reporter: Alexis Midon
> Fix For: 1.4
>
> Attachments: buildr-223.patch.txt
>
>
> From a request on nuildr-dev mailing list:
> Next, our commit messages have a special format (we start with keywords), and we cannot use the buildr release without modifications.
> I can patch the Release class in my buildfile, but perhaps something similar to the release attribute in buildr 1.3.3 would be possible, like in the
> following exemple ?
> Release.tag_name = lambda { |ver| "foo-#{ver}" }
> Release.commit_format = lambda { |msg| "ADD: #{msg}" }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.