You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/22 00:04:44 UTC

[GitHub] [pulsar] dlg99 opened a new pull request #14780: Handle kafka sinks that return immutable maps as configs

dlg99 opened a new pull request #14780:
URL: https://github.com/apache/pulsar/pull/14780


   ### Motivation
   
   Some Kafka sinks return immutable map as config (e.g. ones written in Scala)
   As result KCA sink fail to start/throws exception on attempt to modify such config.
   
   ### Modifications
   
   Handle this situation.
   
   ### Verifying this change
   
   Modified test connector to return Unmodifiable map, verified it breaks the sink tests, fixed.
   
   ### Does this pull request potentially affect one of the following parts:
   
   No
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #14780: Handle kafka sinks that return immutable maps as configs

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #14780:
URL: https://github.com/apache/pulsar/pull/14780


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #14780: Handle kafka sinks that return immutable maps as configs

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #14780:
URL: https://github.com/apache/pulsar/pull/14780#issuecomment-1074846831


   @dlg99 patch does not apply to branch-2.8 and branch-2.9 
   please create a new PR
   
   I was only able to cherry-pick to branch-2.10 (@codelipenghui FYI)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dlg99 commented on pull request #14780: Handle kafka sinks that return immutable maps as configs

Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #14780:
URL: https://github.com/apache/pulsar/pull/14780#issuecomment-1075439229


   @eolivelli https://github.com/apache/pulsar/pull/14806 - it cherry-picks into 2.8 cleanly, but I can create a separate PR if needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org