You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2022/10/19 18:40:28 UTC

[GitHub] [unomi] anatol-sialitski opened a new pull request, #525: UNOMI-617: Update filters to adapt to interests data model changes

anatol-sialitski opened a new pull request, #525:
URL: https://github.com/apache/unomi/pull/525

   [UNOMI-617] Update filters to adapt to interests data model changes
   
   In this PR was done:
   - Adopted conditions and condition parser for interests
   - Adopted ProfileInterestsDataFetcher according to the new data model
   - Added the ability to filter interests by viewIds. It was missed 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] jkevan commented on pull request #525: UNOMI-617: Update filters to adapt to interests data model changes

Posted by GitBox <gi...@apache.org>.

jkevan commented on PR #525:
URL: https://github.com/apache/unomi/pull/525#issuecomment-1359030564

   Thx for the update, code looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] anatol-sialitski commented on pull request #525: UNOMI-617: Update filters to adapt to interests data model changes

Posted by GitBox <gi...@apache.org>.

anatol-sialitski commented on PR #525:
URL: https://github.com/apache/unomi/pull/525#issuecomment-1306857602

   Yes, I will update my PR. I hope I will time on this week  do to that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] Fgerthoffert merged pull request #525: UNOMI-617: Update filters to adapt to interests data model changes

Posted by GitBox <gi...@apache.org>.

Fgerthoffert merged PR #525:
URL: https://github.com/apache/unomi/pull/525


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] jkevan commented on pull request #525: UNOMI-617: Update filters to adapt to interests data model changes

Posted by GitBox <gi...@apache.org>.

jkevan commented on PR #525:
URL: https://github.com/apache/unomi/pull/525#issuecomment-1306851330

   Thx for the update on the new data model.
   
   There is a failure on the tests:
   
   ```
   Error:  Errors: 
   Error:    GraphQLProfilePropertiesIT.testGetProfile_CDPFields:124 » NullPointer
   ```
   
   Is it related to your modification ?
   
   Best regards.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org