You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/12 09:07:35 UTC
[GitHub] [iotdb] jxlgzwh opened a new pull request #2822: optimize WAL has three ways to be flashed to disk
jxlgzwh opened a new pull request #2822:
URL: https://github.com/apache/iotdb/pull/2822
optimize code and fix doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 merged pull request #2822: optimize WAL has three ways to be flashed to disk
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #2822:
URL: https://github.com/apache/iotdb/pull/2822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #2822: optimize WAL has three ways to be flashed to disk
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2822:
URL: https://github.com/apache/iotdb/pull/2822#discussion_r593685857
##########
File path: server/src/test/java/org/apache/iotdb/db/writelog/io/LogWriterReaderTest.java
##########
@@ -26,16 +26,13 @@
import org.apache.iotdb.db.qp.physical.crud.DeletePlan;
import org.apache.iotdb.db.qp.physical.crud.InsertRowPlan;
import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
-
import org.junit.Before;
import org.junit.Test;
-
import java.io.File;
import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.List;
-
Review comment:
we use command "mvn spotless:apply", which can alter code fomart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org