[GitHub] [felix-dev] kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #1: FELIX-6232 - adding option to install parallel version of bundle
URL: https://github.com/apache/felix-dev/pull/1#discussion_r386324692
 
 

 ##########
 File path: webconsole/src/main/java/org/apache/felix/webconsole/internal/core/BundlesServlet.java
 ##########
 @@ -1642,8 +1648,10 @@ private void installBundle( String location, File bundleFile, int startLevel, bo
                 Bundle[] bundles = BundleContextUtil.getWorkingBundleContext(this.getBundleContext()).getBundles();
                 for ( int i = 0; i < bundles.length; i++ )
                 {
+                    boolean isSameBSN = (bundles[i].getSymbolicName() != null && bundles[i].getSymbolicName().equals( symbolicName ));
 
 Review comment:
   I think you can just do `symbolicName.equals(bundles[i].getSymbolicName())` as `symbolicName` can't be `null` here!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services