[PATCH] win32 won't link

["John K. Sterling" <st...@covalent.net>]

seems the cvs tree isn't building for me on winnt (case anyone is 
interested) defining ap_ugly_hack in the .c file (it was only
declared in the .h file) allows apache to link....


--- http_main.c_bk      Tue Oct 31 18:33:56 2000
+++ http_main.c	Tue Oct 31
18:28:12 2000
@@ -69,6 +69,9 @@
 #include "apr_getopt.h"
 #include "ap_mpm.h"
 
+
+void *ap_ugly_hack;
+
 /* WARNING: Win32 binds http_main.c dynamically to the server. Please place 
  *          extern functions and global data in another appropriate module.
  *

Re: [PATCH] win32 won't link

[rb...@covalent.net]

Ahhh....  I should have thought of this.  That ugly hack is just that, an
ugly hack to get things working on Unix.  This problem will plague any
platform that doesn't use buildconf.  Defining ap_ugly_hack in the .c file
isn't the correct solution, because that symbol does exist on platforms
that use buildconf.  We either need an #ifdef for Windows, of Windows
needs to create it's own exports.c file.  I personally wouldn't mind just
adding this patch with an ifdef.

Ryan

On Tue, 31 Oct 2000, John K. Sterling wrote:

> 
> seems the cvs tree isn't building for me on winnt (case anyone is 
> interested) defining ap_ugly_hack in the .c file (it was only
> declared in the .h file) allows apache to link....
> 
> 
> --- http_main.c_bk      Tue Oct 31 18:33:56 2000
> +++ http_main.c	Tue Oct 31
> 18:28:12 2000
> @@ -69,6 +69,9 @@
>  #include "apr_getopt.h"
>  #include "ap_mpm.h"
>  
> +
> +void *ap_ugly_hack;
> +
>  /* WARNING: Win32 binds http_main.c dynamically to the server. Please place 
>   *          extern functions and global data in another appropriate module.
>   *
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------