You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/25 10:51:53 UTC

[GitHub] [echarts] pissang edited a comment on pull request #14569: Fix(brush): clamp range when brush

pissang edited a comment on pull request #14569:
URL: https://github.com/apache/echarts/pull/14569#issuecomment-826303142


   Found some exists very old bad designs durging the review. Going to fix it in a separate PR
   
   For example:
   The second parameter View#dataToPoint and Geo#dataToPoint don't follow other coordinate systems, which use `clamp` as the second parameter. It's easy to pass wrong value.
   https://github.com/apache/echarts/blob/master/src/coord/View.ts#L271


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org