You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/30 07:23:07 UTC

[GitHub] [hbase] virajjasani commented on pull request #1793: HBASE-23941 : FilterBy operator support in get_slowlog_responses API

virajjasani commented on pull request #1793:
URL: https://github.com/apache/hbase/pull/1793#issuecomment-636291771


   > This change looks good to me.
   > 
   > Reading through your examples, I realize it would have been nice if we supported filter operations other than equality. String prefix and regex come to mind, for matching tables, say, by namespace, or regions by rowkey range. Another idea is CIDR matching of client IP addresses by subnet.
   
   That's quite interesting idea 👍 
   Table search is already included with `regionName.startsWith()` sort of expression. Similarly, allowing search with operators other than just equality should help make life even simpler. Let me have a follow up Jira.
   
   Thanks @bharathv @ndimiduk for the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org