You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/11/24 07:21:57 UTC

Review Request 28327: CLOUDSTACK-7938: Marvin - Create a new section in test_data.py for configurable data and change test cases accordingly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28327/
-----------------------------------------------------------

Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7938
    https://issues.apache.org/jira/browse/CLOUDSTACK-7938


Repository: cloudstack-git


Description
-------

Separating the configurable data from test_data.py and putting it in different section so that we know which data needs changes according to the setup and environment.

Made according changes in test cases.
Removed the static data from the test cases.
Removed method from common.py which is used no more.


Diffs
-----

  test/integration/component/test_lb_secondary_ip.py 841257f 
  test/integration/component/test_netscaler_configs.py 91fb85b 
  test/integration/component/test_netscaler_lb.py e3d65bb 
  test/integration/component/test_netscaler_lb_algo.py 0d571b4 
  test/integration/component/test_netscaler_lb_sticky.py a5f55a8 
  test/integration/component/test_persistent_networks.py f782700 
  test/integration/component/test_portable_ip.py cf0cb3b 
  test/integration/smoke/test_primary_storage.py 310afca 
  tools/marvin/marvin/config/test_data.py 2f97d5f 
  tools/marvin/marvin/lib/common.py 63662b9 

Diff: https://reviews.apache.org/r/28327/diff/


Testing
-------

Yes.

All test suites tested and changes working fine.


Thanks,

Gaurav Aradhye

Re: Review Request 28327: CLOUDSTACK-7938: Marvin - Create a new section in test_data.py for configurable data and change test cases accordingly

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28327/#review62974
-----------------------------------------------------------

Ship it!


d7940cca1e731ad92f566d16ef040afbc407932a 4.5
684268f4c3a6be1441f1f47df2979185c91bfcaf master

- SrikanteswaraRao Talluri


On Nov. 24, 2014, 6:21 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28327/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 6:21 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7938
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7938
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Separating the configurable data from test_data.py and putting it in different section so that we know which data needs changes according to the setup and environment.
> 
> Made according changes in test cases.
> Removed the static data from the test cases.
> Removed method from common.py which is used no more.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_lb_secondary_ip.py 841257f 
>   test/integration/component/test_netscaler_configs.py 91fb85b 
>   test/integration/component/test_netscaler_lb.py e3d65bb 
>   test/integration/component/test_netscaler_lb_algo.py 0d571b4 
>   test/integration/component/test_netscaler_lb_sticky.py a5f55a8 
>   test/integration/component/test_persistent_networks.py f782700 
>   test/integration/component/test_portable_ip.py cf0cb3b 
>   test/integration/smoke/test_primary_storage.py 310afca 
>   tools/marvin/marvin/config/test_data.py 2f97d5f 
>   tools/marvin/marvin/lib/common.py 63662b9 
> 
> Diff: https://reviews.apache.org/r/28327/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> All test suites tested and changes working fine.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>