You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Kris M (JIRA)" <ji...@apache.org> on 2018/05/29 14:55:00 UTC
[jira] [Comment Edited] (GROOVY-7407) Compilation not thread safe
if Grape / Ivy is used in Groovy scripts
[ https://issues.apache.org/jira/browse/GROOVY-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493641#comment-16493641 ]
Kris M edited comment on GROOVY-7407 at 5/29/18 2:54 PM:
---------------------------------------------------------
[~jglick@netbeans.org] [https://issues.jenkins-ci.org/browse/JENKINS-48974]
I have also seen this in our jenkins pipelines
was (Author: krismulica):
[~jglick@netbeans.org] https://issues.jenkins-ci.org/browse/JENKINS-48974
> Compilation not thread safe if Grape / Ivy is used in Groovy scripts
> --------------------------------------------------------------------
>
> Key: GROOVY-7407
> URL: https://issues.apache.org/jira/browse/GROOVY-7407
> Project: Groovy
> Issue Type: Bug
> Components: Compiler, Grape
> Affects Versions: 2.4.3
> Environment: Essentially independent of the environment, as long as Groovy scripts use Grape; also this bug seems to be present since at least Groovy 1.7.5.
> Reporter: Jex Jexler
> Priority: Minor
> Labels: Compile, Grape, Groovy, Ivy
> Attachments: GROOVY-7407-Jenkins-Pipeline.txt, GrabConcurrencyTest.java, GrapeAndGroovyShellConcurrencyTest.java, GroovyCompileConcurrencyTest.java, WorkaroundGroovy7407WrappingGrapeEngine.java, stacktrace-GrapeAndGroovyShellConcurrencyTest-1.txt, stacktrace-GrapeAndGroovyShellConcurrencyTest-2.txt, stacktrace-GroovyCompileConcurrencyTest-1.txt, stacktrace-GroovyCompileConcurrencyTest-2.txt
>
>
> If Groovy scripts that import the same libraries via Grape are compiled in separate threads, compilation may fail due to race conditions.
> This does not happen if several threads use the *same* instance of GroovyClassLoader (GCL), because parseClass() uses synchronization.
> But as soon as different GCLs are used in separate threads or if the compiler is used directly (CompilationUnit.compile()), the issue occurs and compilation can fail.
> Two Java unit tests have be attached, which reproduce the issue, although this cannot be guaranteed with 100% certainty, because there is a race condition.
> Two different stacktraces have been observed for each unit test (with origins in Grape and in Ivy), which have also been attached (plus in a different environment (Tomcat webapp CentOS) once a an exception down in Ivy had been observed that seemed to be related to unzipping a JAR file, but no precise record of that exists any more).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)