You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/27 15:37:51 UTC

[GitHub] [lucene] uschindler opened a new pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

uschindler opened a new pull request #321:
URL: https://github.com/apache/lucene/pull/321


   See https://github.com/apache/lucene/pull/308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #321:
URL: https://github.com/apache/lucene/pull/321#issuecomment-928064227


   I added a simple test that should catch all boundaries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] jpountz commented on pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #321:
URL: https://github.com/apache/lucene/pull/321#issuecomment-928029704


   My guess is that such a small buffer size would always be a mistake, so better fail than silently round?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #321:
URL: https://github.com/apache/lucene/pull/321#issuecomment-928009646


   Thanks Adrien.
   
   About the API change: Instead of throwing IAE, I can also round up the buffer size in ctor if it is <8.
   What do you think?
   
   Uwe


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler merged pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #321:
URL: https://github.com/apache/lucene/pull/321


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] jpountz commented on pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #321:
URL: https://github.com/apache/lucene/pull/321#issuecomment-928051227


   +1 to add a test for ints/longs written on boundaries


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #321: LUCENE-10125: Optimize primitive writes in OutputStreamIndexOutput

Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #321:
URL: https://github.com/apache/lucene/pull/321#issuecomment-928048371


   OK, then let's keep it like that.
   
   Do you think we should add a test (more or less a clone of TestByteArrayDataOutput)? I have one ready already (it just writes some primitives and checks output size and reads again from an array.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org