You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/05/25 23:07:12 UTC
Review Request 59583: Added a test to verify executor driver message
dropping behavior.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-7542
https://issues.apache.org/jira/browse/MESOS-7542
Repository: mesos
Description
-------
This patch adds a test which verifies that the executor driver will drop
RunTaskMessages when it is not connected to the agent.
Diffs
-----
src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
Diff: https://reviews.apache.org/r/59583/diff/1/
Testing
-------
`GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176194
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 25, 2017, 11:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 11:07 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
>
>
> Diff: https://reviews.apache.org/r/59583/diff/1/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On May 30, 2017, 7:43 p.m., Mesos Reviewbot Windows wrote:
> > Bad patch!
> >
> > Reviews applied: [59583, 59545, 59463, 59461, 59460]
> >
> > Failed command: python support/apply-reviews.py -n -r 59545
> >
> > Error:
> > error: patch failed: src/tests/slave_tests.cpp:7210
> > error: src/tests/slave_tests.cpp: patch does not apply
> >
> > Full log: http://mesos-winbot.westus.cloudapp.azure.com/../logs/console
FYI the Windows ReviewBot is blocked from applying to master by https://reviews.apache.org/r/59500/
Bug Joe!
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176337
-----------------------------------------------------------
On May 30, 2017, 11:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
>
>
> Diff: https://reviews.apache.org/r/59583/diff/3/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176337
-----------------------------------------------------------
Bad patch!
Reviews applied: [59583, 59545, 59463, 59461, 59460]
Failed command: python support/apply-reviews.py -n -r 59545
Error:
error: patch failed: src/tests/slave_tests.cpp:7210
error: src/tests/slave_tests.cpp: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/../logs/console
- Mesos Reviewbot Windows
On May 27, 2017, 1:33 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 27, 2017, 1:33 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
>
>
> Diff: https://reviews.apache.org/r/59583/diff/2/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176405
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 30, 2017, 11:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
>
>
> Diff: https://reviews.apache.org/r/59583/diff/3/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176401
-----------------------------------------------------------
Bad patch!
Reviews applied: [59583, 59545, 59463, 59461, 59460]
Failed command: python support/apply-reviews.py -n -r 59545
Error:
error: patch failed: src/tests/slave_tests.cpp:7210
error: src/tests/slave_tests.cpp: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/../logs/console
- Mesos Reviewbot Windows
On May 30, 2017, 11:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
>
>
> Diff: https://reviews.apache.org/r/59583/diff/3/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176418
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59460, 59461, 59463, 59545, 59583]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 30, 2017, 11:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:30 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
>
>
> Diff: https://reviews.apache.org/r/59583/diff/3/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/
-----------------------------------------------------------
(Updated May 30, 2017, 11:30 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-7542
https://issues.apache.org/jira/browse/MESOS-7542
Repository: mesos
Description
-------
This patch adds a test which verifies that the executor driver will drop
RunTaskMessages when it is not connected to the agent.
Diffs (updated)
-----
src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
Diff: https://reviews.apache.org/r/59583/diff/3/
Changes: https://reviews.apache.org/r/59583/diff/2-3/
Testing
-------
`GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176286
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59460, 59461, 59463, 59545, 59583]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 27, 2017, 1:33 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 27, 2017, 1:33 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
>
>
> Diff: https://reviews.apache.org/r/59583/diff/2/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/
-----------------------------------------------------------
(Updated May 27, 2017, 1:33 a.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
Bugs: MESOS-7542
https://issues.apache.org/jira/browse/MESOS-7542
Repository: mesos
Description
-------
This patch adds a test which verifies that the executor driver will drop
RunTaskMessages when it is not connected to the agent.
Diffs (updated)
-----
src/tests/slave_tests.cpp 927b9c3fbc3373b49c799da6e3f770b73964f9e5
Diff: https://reviews.apache.org/r/59583/diff/2/
Changes: https://reviews.apache.org/r/59583/diff/1-2/
Testing
-------
`GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 59583: Added a test to verify executor driver
message dropping behavior.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59583/#review176198
-----------------------------------------------------------
Bad patch!
Reviews applied: [59583, 59582]
Failed command: python support/apply-reviews.py -n -r 59583
Error:
2017-05-26 15:19:47 URL:https://reviews.apache.org/r/59583/diff/raw/ [4481/4481] -> "59583.patch" [1]
error: patch failed: src/tests/slave_tests.cpp:7004
error: src/tests/slave_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/18191/console
- Mesos Reviewbot
On May 25, 2017, 11:07 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59583/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 11:07 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-7542
> https://issues.apache.org/jira/browse/MESOS-7542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a test which verifies that the executor driver will drop
> RunTaskMessages when it is not connected to the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df
>
>
> Diff: https://reviews.apache.org/r/59583/diff/1/
>
>
> Testing
> -------
>
> `GTEST_FILTER="*DisconnectedExecutorDropsMessages*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>