You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by spasam <gi...@git.apache.org> on 2017/07/30 22:21:01 UTC
[GitHub] orc pull request #144: [ORC-219] Boolean and timestamp converter for CSV.
GitHub user spasam opened a pull request:
https://github.com/apache/orc/pull/144
[ORC-219] Boolean and timestamp converter for CSV.
Added support for boolean and timestamp readers for CSV conversion.
Fixed deprecated JUnit imports in tests
Fixed deprecated GnuParser/Options
Upgraded JUnit to 4.12
Test CSV convert with Posgres TSV output that has boolean and timestamp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/spasam/orc csv
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
commit c836fb9a7014a025b2d1279dfa460bfb8a557738
Author: Seshu Pasam <sp...@uptycs.com>
Date: 2017-07-30T22:16:30Z
[ORC-219] Boolean and timestamp converter for CSV.
Added support for boolean and timestamp readers for CSV conversion.
Fixed deprecated JUnit imports in tests
Fixed deprecated GnuParser/Options
Upgraded JUnit to 4.12
Test CSV convert with Posgres TSV output that has boolean and timestamp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #144: [ORC-219] Boolean and timestamp converter for CSV.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476321
--- Diff: java/core/pom.xml ---
@@ -57,6 +57,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
--- End diff --
Let's keep this dependency in the tools module rather than core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #144: [ORC-219] Boolean and timestamp converter for CSV.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476392
--- Diff: java/core/src/java/org/apache/orc/RecordReader.java ---
@@ -20,11 +20,15 @@
import java.io.IOException;
import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
+import org.threeten.bp.format.DateTimeFormatter;
/**
* A row-by-row iterator for ORC files.
*/
public interface RecordReader extends AutoCloseable {
+ DateTimeFormatter DATE_TIME_FORMATTER = DateTimeFormatter.ofPattern(
--- End diff --
This should move the the CSV converter in tools.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #144: [ORC-219] Boolean and timestamp converter for CSV.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476844
--- Diff: java/pom.xml ---
@@ -637,7 +637,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.11</version>
+ <version>4.12</version>
--- End diff --
Did you need this version change or was it an unassociated change? As with fixing the imports, you don't want to tie random changes into a single patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #144: [ORC-219] Boolean and timestamp converter for CSV.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #144: [ORC-219] Boolean and timestamp converter for CSV.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476624
--- Diff: java/bench/src/java/org/apache/orc/bench/Driver.java ---
@@ -23,7 +23,6 @@
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
-import org.apache.hadoop.conf.Configuration;
--- End diff --
In general, you shouldn't fix imports in files that your patch isn't touching. Go ahead and leave them in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---