You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/09 20:48:50 UTC

Review Request 36362: Upgrade to gradle 2.5.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.

Repository: aurora

Description
-------

Upgrade to gradle 2.5. Release notes here: https://docs.gradle.org/current/release-notes
In particular, this feature might be intersting to try out:
```
The new “Continuous build” support brings capability to have Gradle automatically initiate a build in response to file system changes. This works with any build and has many applications. For example, it can be used to get continuous compile and test, giving more immediate feedback. As it works with any Gradle task, it is equally applicable to documentation generation tasks and more. Upcoming versions of Gradle will build on this capability to facilitate reloading applications and the like under development in response to changes, providing a fast feedback local development loop.
```
Note: i had to resort to `git clean -fdx` to fully wipe out my intellij project, as i encountered a problem running unit tests due to a reported module cycle (somehow related to annotation processing). Gradle 2.5 does indeed have changes in this area, but clearing out the old project

Diffs
-----

buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab
gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f

Diff: https://reviews.apache.org/r/36362/diff/

Testing
-------

./gradlew build -Pq
./gradlew idea, ran unit tests
Played with continuous build: ./gradlew -t build

Thanks,

Bill Farner

Re: Review Request 36362: Upgrade to gradle 2.5.

Posted by Bill Farner <wf...@apache.org>.


> On July 9, 2015, 6:54 p.m., Zameer Manji wrote:
> > Please complete your commit message.

Sorry about that, not sure how it was cut off.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/#review91148
-----------------------------------------------------------


On July 9, 2015, 6:48 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36362/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 6:48 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to gradle 2.5.  Release notes here: https://docs.gradle.org/current/release-notes
> In particular, this feature might be intersting to try out:
> ```
> The new “Continuous build” support brings capability to have Gradle automatically initiate a build in response to file system changes. This works with any build and has many applications. For example, it can be used to get continuous compile and test, giving more immediate feedback. As it works with any Gradle task, it is equally applicable to documentation generation tasks and more. Upcoming versions of Gradle will build on this capability to facilitate reloading applications and the like under development in response to changes, providing a fast feedback local development loop.
> ```
> Note: i had to resort to `git clean -fdx` to fully wipe out my intellij project, as i encountered a problem running unit tests due to a reported module cycle (somehow related to annotation processing).  Gradle 2.5 does indeed have changes in this area, but clearing out the old project
> 
> 
> Diffs
> -----
> 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f 
> 
> Diff: https://reviews.apache.org/r/36362/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> ./gradlew idea, ran unit tests
> Played with continuous build: ./gradlew -t build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36362: Upgrade to gradle 2.5.

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/#review91148
-----------------------------------------------------------

Ship it!


Please complete your commit message.

- Zameer Manji


On July 9, 2015, 11:48 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36362/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 11:48 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to gradle 2.5.  Release notes here: https://docs.gradle.org/current/release-notes
> In particular, this feature might be intersting to try out:
> ```
> The new “Continuous build” support brings capability to have Gradle automatically initiate a build in response to file system changes. This works with any build and has many applications. For example, it can be used to get continuous compile and test, giving more immediate feedback. As it works with any Gradle task, it is equally applicable to documentation generation tasks and more. Upcoming versions of Gradle will build on this capability to facilitate reloading applications and the like under development in response to changes, providing a fast feedback local development loop.
> ```
> Note: i had to resort to `git clean -fdx` to fully wipe out my intellij project, as i encountered a problem running unit tests due to a reported module cycle (somehow related to annotation processing).  Gradle 2.5 does indeed have changes in this area, but clearing out the old project
> 
> 
> Diffs
> -----
> 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f 
> 
> Diff: https://reviews.apache.org/r/36362/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> ./gradlew idea, ran unit tests
> Played with continuous build: ./gradlew -t build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36362: Upgrade to gradle 2.5.

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/#review91152
-----------------------------------------------------------

Ship it!


Master (b86b293) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 9, 2015, 7:03 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36362/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 7:03 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to gradle 2.5.  Release notes here: https://docs.gradle.org/current/release-notes
> In particular, this feature might be intersting to try out:
> ```
> The new “Continuous build” support brings capability to have Gradle automatically initiate a build in response to file system changes. This works with any build and has many applications. For example, it can be used to get continuous compile and test, giving more immediate feedback. As it works with any Gradle task, it is equally applicable to documentation generation tasks and more. Upcoming versions of Gradle will build on this capability to facilitate reloading applications and the like under development in response to changes, providing a fast feedback local development loop.
> ```
> Note: i had to resort to `git clean -fdx` to fully wipe out my intellij project, as i encountered a problem running unit tests due to a reported module cycle (somehow related to annotation processing).  Gradle 2.5 does indeed have changes in this area, but clearing out the old project corrected the issue i encountered.
> 
> 
> Diffs
> -----
> 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f 
> 
> Diff: https://reviews.apache.org/r/36362/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> ./gradlew idea, ran unit tests
> Played with continuous build: ./gradlew -t build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36362: Upgrade to gradle 2.5.

Posted by Bill Farner <wf...@apache.org>.


> On July 9, 2015, 7:40 p.m., Stephan Erb wrote:
> > You forgot to update the debian and rpm dependencies.

Good catch!  I'll follow up to address that.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/#review91170
-----------------------------------------------------------


On July 9, 2015, 7:03 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36362/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 7:03 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to gradle 2.5.  Release notes here: https://docs.gradle.org/current/release-notes
> In particular, this feature might be intersting to try out:
> ```
> The new “Continuous build” support brings capability to have Gradle automatically initiate a build in response to file system changes. This works with any build and has many applications. For example, it can be used to get continuous compile and test, giving more immediate feedback. As it works with any Gradle task, it is equally applicable to documentation generation tasks and more. Upcoming versions of Gradle will build on this capability to facilitate reloading applications and the like under development in response to changes, providing a fast feedback local development loop.
> ```
> Note: i had to resort to `git clean -fdx` to fully wipe out my intellij project, as i encountered a problem running unit tests due to a reported module cycle (somehow related to annotation processing).  Gradle 2.5 does indeed have changes in this area, but clearing out the old project corrected the issue i encountered.
> 
> 
> Diffs
> -----
> 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f 
> 
> Diff: https://reviews.apache.org/r/36362/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> ./gradlew idea, ran unit tests
> Played with continuous build: ./gradlew -t build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36362: Upgrade to gradle 2.5.

Posted by Stephan Erb <st...@dev.static-void.de>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36362/#review91170
-----------------------------------------------------------


You forgot to update the debian and rpm dependencies.

- Stephan Erb


On July 9, 2015, 9:03 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36362/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 9:03 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade to gradle 2.5.  Release notes here: https://docs.gradle.org/current/release-notes
> In particular, this feature might be intersting to try out:
> ```
> The new “Continuous build” support brings capability to have Gradle automatically initiate a build in response to file system changes. This works with any build and has many applications. For example, it can be used to get continuous compile and test, giving more immediate feedback. As it works with any Gradle task, it is equally applicable to documentation generation tasks and more. Upcoming versions of Gradle will build on this capability to facilitate reloading applications and the like under development in response to changes, providing a fast feedback local development loop.
> ```
> Note: i had to resort to `git clean -fdx` to fully wipe out my intellij project, as i encountered a problem running unit tests due to a reported module cycle (somehow related to annotation processing).  Gradle 2.5 does indeed have changes in this area, but clearing out the old project corrected the issue i encountered.
> 
> 
> Diffs
> -----
> 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f 
> 
> Diff: https://reviews.apache.org/r/36362/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> ./gradlew idea, ran unit tests
> Played with continuous build: ./gradlew -t build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 36362: Upgrade to gradle 2.5.

Posted by Bill Farner <wf...@apache.org>.

(Updated July 9, 2015, 7:03 p.m.)

Review request for Aurora and Zameer Manji.

Repository: aurora

Description (updated)
-------

Diffs
-----

buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab
gradle/wrapper/gradle-wrapper.properties e713793f7d63e65ea68e091b959ba6a68352b48f

Diff: https://reviews.apache.org/r/36362/diff/

Testing
-------

./gradlew build -Pq
./gradlew idea, ran unit tests
Played with continuous build: ./gradlew -t build

Thanks,

Bill Farner