You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 11:24:41 UTC
[jira] [Commented] (BEAM-1272) Align the naming of
"generateInitialSplits" and "splitIntoBundles" to better reflect their
intention
[ https://issues.apache.org/jira/browse/BEAM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967430#comment-15967430 ]
ASF GitHub Bot commented on BEAM-1272:
--------------------------------------
GitHub user echauchot opened a pull request:
https://github.com/apache/beam/pull/2523
[BEAM-1272] Align the naming of "generateInitialSplits" and "splitIntoBundles" to better reflect their intention
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
As discussed in the ML, rename `generateInitialSplits` and `splitIntoBundles` methods to `splitIntoSubSources` as well as @Test methods and description in javadoc.
---
R: @jkff
R: @staslev
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echauchot/beam BEAM-1272-renaming_generateInitialSplits_and_splitIntoBundles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2523
----
commit da52c7bff0004553d3cb605e843d88f4aa5ac820
Author: Etienne Chauchot <ec...@gmail.com>
Date: 2017-04-13T08:55:20Z
[BEAM-1272] Align the naming of "generateInitialSplits" and "splitIntoBundles" to better reflect their intention
----
> Align the naming of "generateInitialSplits" and "splitIntoBundles" to better reflect their intention
> ----------------------------------------------------------------------------------------------------
>
> Key: BEAM-1272
> URL: https://issues.apache.org/jira/browse/BEAM-1272
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Stas Levin
> Assignee: Etienne Chauchot
> Priority: Minor
> Fix For: First stable release
>
>
> See [dev list thread|https://lists.apache.org/thread.html/ac5717566707153e85da880cc75c8d047e1c6606861777670bb9107c@%3Cdev.beam.apache.org%3E].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)