You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/07/27 20:20:34 UTC

[GitHub] storm pull request #2245: Restore issues missing from changelog since fb2446...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2245

    Restore issues missing from changelog since fb2446075de202387658b0cc8…

    …434ee53ded5d35a
    
    See https://github.com/apache/storm/commit/fb2446075de202387658b0cc8434ee53ded5d35a
    
    I've grepped the log for the added issue numbers on 1.1.x-branch and the associated commits appear to be in 1.x but not 1.1.x, so they likely belong in 1.2.0. On master these issues are listed in 2.0.0, which is maybe also wrong(?)
    
    The two removed issues are duplicate, 2432 isn't fixed in 1.0.0 based on the 1.0.0 tag, and 2343 is listed twice in 1.1.1
    
    ping @HeartSaVioR 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm restore-changelog-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2245
    
----
commit 4ca12ff5c806cfc3991cc9e8ff6cf5a7715b37ce
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-07-27T19:50:10Z

    Restore issues missing from changelog since fb2446075de202387658b0cc8434ee53ded5d35a

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2245: Restore issues missing from changelog since fb2446075de20...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2245
  
    +1 You can merge this without waiting 24hr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2245: Restore issues missing from changelog since fb2446...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2245


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2245: Restore issues missing from changelog since fb2446075de20...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2245
  
    As you may know, you can even just made a change if it was wrong. Now you also think it's hard to maintain CHANGELOG, let's see how the discussion goes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2245: Restore issues missing from changelog since fb2446075de20...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2245
  
    Thanks @HeartSaVioR. I'll make similar changes quietly on master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---