[jira] [Updated] (SOLR-8396) Add support for PointFields in Solr

["Tomás Fernández Löbbe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomás Fernández Löbbe updated SOLR-8396:
----------------------------------------
    Attachment: SOLR-8396.patch

Uploading a patch updated to current master. I think it’s mostly done, so this is a good time to review if you are interested in the feature. I plan to commit to master soon and let it bake there some time before moving to branch 6_x. There are no big issues with compatibility so I think it should be fine to backport at some point. The last changes are not in the branch, I’m trying to avoid an avalanche of “commit emails” and possibly updates to Jiras due to the recent merge, so please review the patch. I’m leaving some tasks for followup Jiras that can be fixed/discussed separately:

* LukeRequestHandler doesn’t populate docFreq for PointFields
* Implement DatePointField
* Implement support for MV DocValues in PointFields
* Add method toInternalByteRef to FieldType and possibly deprecate toInternal()
* Add support for PointFields in FacetModule (JSON Facets)
* Add PointFields as pField in example schemas
* Add support for facet method “fc” with PointFields (only “FCS” is currently supported for field faceting)
* Add support for grouping with PointFIelds
* Add support for pivot faceting with PointFields
* Add support for ExpandComponent with PointFIelds
* Add support for CollapseQParser with PointFields


bq. ...SOLR-9786 should cause the query parser to automatically delegate to FieldType.getSetQuery() for queries on more than one point (
Great. I had added a {{getSetQuery}} method in PointField class, I removed it and I’m now using super’s (implemented in the different Point FieldType classes). Also added validation in {{TestSolrQueryParser.java}}

bq. The first time we went through this transition, "int" was renamed to "pint" in the example schema, and then a new "int" was created to use trie (numeric)….
+1. But in any case, since I’m leaving the changes to the example {{schema.xml}} out of this patch, this can be further discussed in followup Jira if anyone has concerns with the approach.

Not sure if the “solr.tests.preferPointFields” changes I did are implemented in the correct way, I’ll review that before committing. Feel free to comment on that too.


> Add support for PointFields in Solr
> -----------------------------------
>
>                 Key: SOLR-8396
>                 URL: https://issues.apache.org/jira/browse/SOLR-8396
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ishan Chattopadhyaya
>         Attachments: SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch
>
>
> In LUCENE-6917, [~mikemccand] mentioned that DimensionalValues are better than NumericFields in most respects. We should explore the benefits of using it in Solr and hence, if appropriate, switch over to using them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org