[jira] [Commented] (SOLR-6693) Start script for windows fails with 32bit JRE

["Christopher Hewitt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305203#comment-14305203 ] 

Christopher Hewitt commented on SOLR-6693:
------------------------------------------

Occurs in Windows 7, 32bit jre (or jdk);

It actually comes from proper escaping/encapsulation of parentheses within variables, and the nested IF's ():
{code}
IF "%verbose%"=="1" (
  @echo Using Solr root directory: %SOLR_TIP%
  @echo Using Java: %JAVA%

  "%JAVA%" -version
)
{code}

A parenthesis in either %SOLR_TIP% or %JAVA% would break this code.
Also in this:

{{"%JAVA_HOME%"\bin\java -version}} does not work in the version check, (returns help --?) however:
{{"%JAVA_HOME%\bin\java" -version}} does.

> Start script for windows fails with 32bit JRE
> ---------------------------------------------
>
>                 Key: SOLR-6693
>                 URL: https://issues.apache.org/jira/browse/SOLR-6693
>             Project: Solr
>          Issue Type: Bug
>          Components: scripts and tools
>    Affects Versions: 4.10.2
>         Environment: WINDOWS 8.1
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: bin\solr.cmd
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6693.patch
>
>
> *Reproduce:*
> # Install JRE8 from www.java.com (typically {{C:\Program Files (x86)\Java\jre1.8.0_25}})
> # Run the command {{bin\solr start -V}}
> The result is:
> {{\Java\jre1.8.0_25\bin\java was unexpected at this time.}}
> *Reason*
> This comes from bad quoting of the {{%SOLR%}} variable. I think it's because of the parenthesis that it freaks out. I think the same would apply for a 32-bit JDK because of the (x86) in the path, but I have not tested.
> Tip: You can remove the line {{@ECHO OFF}} at the top to see exactly which is the offending line
> *Solution*
> Quoting the lines where %JAVA% is printed, e.g. instead of
> {noformat}
>   @echo Using Java: %JAVA%
> {noformat}
> then use
> {noformat}
>   @echo "Using Java: %JAVA%"
> {noformat}
> This is needed several places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org