You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Jiatao Tao (Jira)" <ji...@apache.org> on 2021/04/15 12:54:00 UTC
[jira] [Commented] (CALCITE-4583) Make simplification API more
conservative in "RelBuilder#filter"
[ https://issues.apache.org/jira/browse/CALCITE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322157#comment-17322157 ]
Jiatao Tao commented on CALCITE-4583:
-------------------------------------
Found a improvement for FilterReduceExpressionsRule#onMatch, we used only consider newConditionExp.isAlwaysTrue(), but not newConditionExp.isAlwaysFalse(), this simplify is done by RelBuilder#filter():
!image-2021-04-15-20-52-15-757.png|width=831,height=128!
> Make simplification API more conservative in "RelBuilder#filter"
> ----------------------------------------------------------------
>
> Key: CALCITE-4583
> URL: https://issues.apache.org/jira/browse/CALCITE-4583
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jiatao Tao
> Assignee: Jiatao Tao
> Priority: Critical
> Labels: pull-request-available
> Attachments: image-2021-04-15-20-52-15-757.png
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Previous in CALCITE-2338, we make simplification configurable in most methods except RelBuilder#filter, this Jira aims to cover this method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)