You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@freemarker.apache.org by Mauricio Nuñez <ma...@inversion.cl> on 2018/01/22 13:16:08 UTC
Test fails with locale using comma as decimal separator
Hi!
I've created a PR ( 1 line ).
With my local setup ( es_CL ) , the test suite is reporting an error.
My approach is to define a fixed locale for that test execution.
https://github.com/apache/incubator-freemarker/pull/43
Regards,
Mauricio
Re: Test fails with locale using comma as decimal separator
Posted by Daniel Dekany <dd...@freemail.hu>.
Thanks! (Please close the PR.)
Monday, January 22, 2018, 4:08:27 PM, Mauricio Nuñez wrote:
> Tested! It's working now without my patch.
>
> Regards!
>
>
>
> 2018-01-22 11:46 GMT-03:00 Daniel Dekany <dd...@apache.org>:
>
>> Good catch, however, I rather fix this kind of problem at its root,
>> and initialize the locale to en_US, and also the time zone etc., for
>> all "templatesuite" tests (see my commit). Can you confirm that now
>> the test passes without your patch?
>>
>>
>> Monday, January 22, 2018, 2:16:08 PM, Mauricio Nuñez wrote:
>>
>> > Hi!
>> >
>> > I've created a PR ( 1 line ).
>> > With my local setup ( es_CL ) , the test suite is reporting an error.
>> > My approach is to define a fixed locale for that test execution.
>> >
>> > https://github.com/apache/incubator-freemarker/pull/43
>> >
>> > Regards,
>> >
>> > Mauricio
>>
>> --
>> Thanks,
>> Daniel Dekany
>>
>>
--
Thanks,
Daniel Dekany
Re: Test fails with locale using comma as decimal separator
Posted by Mauricio Nuñez <ma...@inversion.cl>.
Tested! It's working now without my patch.
Regards!
2018-01-22 11:46 GMT-03:00 Daniel Dekany <dd...@apache.org>:
> Good catch, however, I rather fix this kind of problem at its root,
> and initialize the locale to en_US, and also the time zone etc., for
> all "templatesuite" tests (see my commit). Can you confirm that now
> the test passes without your patch?
>
>
> Monday, January 22, 2018, 2:16:08 PM, Mauricio Nuñez wrote:
>
> > Hi!
> >
> > I've created a PR ( 1 line ).
> > With my local setup ( es_CL ) , the test suite is reporting an error.
> > My approach is to define a fixed locale for that test execution.
> >
> > https://github.com/apache/incubator-freemarker/pull/43
> >
> > Regards,
> >
> > Mauricio
>
> --
> Thanks,
> Daniel Dekany
>
>
Re: Test fails with locale using comma as decimal separator
Posted by Daniel Dekany <dd...@apache.org>.
Good catch, however, I rather fix this kind of problem at its root,
and initialize the locale to en_US, and also the time zone etc., for
all "templatesuite" tests (see my commit). Can you confirm that now
the test passes without your patch?
Monday, January 22, 2018, 2:16:08 PM, Mauricio Nuñez wrote:
> Hi!
>
> I've created a PR ( 1 line ).
> With my local setup ( es_CL ) , the test suite is reporting an error.
> My approach is to define a fixed locale for that test execution.
>
> https://github.com/apache/incubator-freemarker/pull/43
>
> Regards,
>
> Mauricio
--
Thanks,
Daniel Dekany