You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:31:08 UTC
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13064: ParameterMarkerExpressionSegment cannot be cast to class LiteralExpressionSegment
strongduanmu commented on a change in pull request #13064:
URL: https://github.com/apache/shardingsphere/pull/13064#discussion_r730246192
##########
File path: shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionEngine.java
##########
@@ -90,9 +92,16 @@
if (projectionSegment instanceof SubqueryProjectionSegment) {
return Optional.of(createProjection((SubqueryProjectionSegment) projectionSegment));
}
+ if (projectionSegment instanceof ParameterMarkerExpressionSegment) {
+ return Optional.ofNullable(createProjection((ParameterMarkerExpressionSegment) projectionSegment));
+ }
// TODO subquery
return Optional.empty();
}
+
+ private ParameterMarkerProjection createProjection(final ParameterMarkerExpressionSegment projectionSegment) {
Review comment:
@LeeGuoPing Can we directly modify this method to return optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org