You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/02/02 07:32:58 UTC
Re: Review Request 30454: LENS-254:
NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE is overriding other causes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30454/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 6:32 a.m.)
Review request for lens.
Bugs: LENS-254
https://issues.apache.org/jira/browse/LENS-254
Repository: lens
Description (updated)
-------
We are keeping Map<Table, List<Error>> in cubequerycontext. To club the errors, I reversed the map to form Map<Error, List<Table>>. Next, List<Table> was converted to a comma_separated_list_of_tables. So we have Map<Error, comma_separated_list_of_tables>, now to show it as a json, I was reversing it again to form Map<comma_separated_list_of_tables, Error> which was wrong. This change modifies the last step to obtain Map<comma_separated_list_of_tables, List<Error>>. In the *wrong* approach `NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE` was overridden by some other error but it was present neverthless. While calculating brief error it was used but in final detailed json it was overridden. With this change this will not happen.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 3f86c6023b78f77b6cdf6fb6fe7187e35bfd0821
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 00483368311f704e1c009542533db11caa9f3bc6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fad50b0d543f50cbb391afd4e00d75ca0ba261e6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d14b095df7dc60c1acd0b507f739fb44e5646952
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java c48cba9e9bdd88946b76369b1c4595d0167ffd14
Diff: https://reviews.apache.org/r/30454/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.111s]
[INFO] Lens .............................................. SUCCESS [1.895s]
[INFO] Lens API .......................................... SUCCESS [5.495s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.609s]
[INFO] Lens Cube ......................................... SUCCESS [6:31.507s]
[INFO] Lens DB storage ................................... SUCCESS [9.774s]
[INFO] Lens Query Library ................................ SUCCESS [5.009s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.088s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.004s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.784s]
[INFO] Lens Server ....................................... SUCCESS [4:30.127s]
[INFO] Lens client ....................................... SUCCESS [19.703s]
[INFO] Lens CLI .......................................... SUCCESS [1:33.683s]
[INFO] Lens Examples ..................................... SUCCESS [1.128s]
[INFO] Lens Distribution ................................. SUCCESS [5.426s]
[INFO] Lens Client Distribution .......................... SUCCESS [6.604s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.438s]
[INFO] Lens Regression ................................... SUCCESS [0.437s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:31.669s
[INFO] Finished at: Fri Jan 30 15:42:18 UTC 2015
[INFO] Final Memory: 100M/1077M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 30454: LENS-254:
NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE is overriding other causes
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30454/
-----------------------------------------------------------
(Updated Feb. 2, 2015, 9:22 a.m.)
Review request for lens.
Bugs: LENS-254
https://issues.apache.org/jira/browse/LENS-254
Repository: lens
Description
-------
We are keeping Map<Table, List<Error>> in cubequerycontext. To club the errors, I reversed the map to form Map<Error, List<Table>>. Next, List<Table> was converted to a comma_separated_list_of_tables. So we have Map<Error, comma_separated_list_of_tables>, now to show it as a json, I was reversing it again to form Map<comma_separated_list_of_tables, Error> which was wrong. This change modifies the last step to obtain Map<comma_separated_list_of_tables, List<Error>>. In the *wrong* approach `NO_FACT_UPDATE_PERIODS_FOR_GIVEN_RANGE` was overridden by some other error but it was present neverthless. While calculating brief error it was used but in final detailed json it was overridden. With this change this will not happen.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 0d62ba85bc389d306771eb922fb49841278fa384
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 394d6df6f3b5c4246637b205dc7b6dcdfdcd5021
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 04b9653dde1f38fe8520f06adc451aab2fd8a710
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 390dee45f553af36676fd39bee75a90052fdec61
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 35c6da0581eea790dd2d52eb4707f0a37b53394e
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d8339bc36bc6ff9ad6c2ba9db045bdfb280e804
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 628a4f52745ea92b202c23ad3484ef9c5f127faa
lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 7a27a08c700904aa704f858d70ac647b5ea1a525
lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java 85cd75a2798c9afaca8761c8b0dcea101a599dc2
lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 3f86c6023b78f77b6cdf6fb6fe7187e35bfd0821
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 9d06c55cb008682c21dbee8c83c5e7e418b29641
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 00483368311f704e1c009542533db11caa9f3bc6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fad50b0d543f50cbb391afd4e00d75ca0ba261e6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d14b095df7dc60c1acd0b507f739fb44e5646952
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java c48cba9e9bdd88946b76369b1c4595d0167ffd14
Diff: https://reviews.apache.org/r/30454/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.111s]
[INFO] Lens .............................................. SUCCESS [1.895s]
[INFO] Lens API .......................................... SUCCESS [5.495s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.609s]
[INFO] Lens Cube ......................................... SUCCESS [6:31.507s]
[INFO] Lens DB storage ................................... SUCCESS [9.774s]
[INFO] Lens Query Library ................................ SUCCESS [5.009s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.088s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [3.004s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.784s]
[INFO] Lens Server ....................................... SUCCESS [4:30.127s]
[INFO] Lens client ....................................... SUCCESS [19.703s]
[INFO] Lens CLI .......................................... SUCCESS [1:33.683s]
[INFO] Lens Examples ..................................... SUCCESS [1.128s]
[INFO] Lens Distribution ................................. SUCCESS [5.426s]
[INFO] Lens Client Distribution .......................... SUCCESS [6.604s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.438s]
[INFO] Lens Regression ................................... SUCCESS [0.437s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:31.669s
[INFO] Finished at: Fri Jan 30 15:42:18 UTC 2015
[INFO] Final Memory: 100M/1077M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal