[GitHub] [pulsar-client-go] GPrabhudas edited a comment on pull request #552: Encryption support in Go client

[GitBox <gi...@apache.org>]

GPrabhudas edited a comment on pull request #552:
URL: https://github.com/apache/pulsar-client-go/pull/552#issuecomment-868295571


   > Thanks for your contribution. I took a quick look and left a few comments. A few suggestions:
   > 
   > In go file names are generally snake case so please try to follow that to keep things consistent. For example this crypto_key_reader.go instead of CryptoKeyReader.go
   > 
   > Can we break this up into multiple pull requests? Can we start with the crypto package that adds the interfaces and base implementations. Then some followup pull requests can be added for the consumer and producer implementation. This will make it easier on people to review the code.
   
   Thanks for the suggestions. Actually I've gone too far to put all the functionality in the single PR. If more people insist to breakdown into multiple pull requests I'll go ahead to do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org