You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2020/06/25 11:20:58 UTC

[GitHub] [ofbiz-plugins] priyasharma1 commented on a change in pull request #33: Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779)

priyasharma1 commented on a change in pull request #33:
URL: https://github.com/apache/ofbiz-plugins/pull/33#discussion_r445486026



##########
File path: bi/groovyScripts/DimensionServices.groovy
##########
@@ -87,7 +87,7 @@ def loadCurrencyDimension() {
                 currencyDim.store()
             }
         } else {
-            currencyDim = delegator.makeValue("CurrencyDimension",["dimensionId":currency.uomId])
+            currencyDim = makeValue("CurrencyDimension",["dimensionId":currency.uomId])

Review comment:
       Thanks @nmalin 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org