You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/04/26 06:55:19 UTC
[GitHub] [phoenix-connectors] chrajeshbabu opened a new pull request, #78: PHOENIX-6694 Share the query plan generated in data source reader in …
chrajeshbabu opened a new pull request, #78:
URL: https://github.com/apache/phoenix-connectors/pull/78
…partition readers to avoid the unnecessary touch basing system tables and meta table in all the workers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #78: PHOENIX-6694 Share the query plan generated in data source reader in …
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #78:
URL: https://github.com/apache/phoenix-connectors/pull/78#issuecomment-1109562273
The test failure looks relevant, @chrajeshbabu .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] joshelser commented on pull request #78: PHOENIX-6694 Share the query plan generated in data source reader in …
Posted by GitBox <gi...@apache.org>.
joshelser commented on PR #78:
URL: https://github.com/apache/phoenix-connectors/pull/78#issuecomment-1109807527
Rajeshbabu said in private that it looks like we can't wholesale copy the `QueryPlan` into the workers, but we have to try to pull out the important details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] stoty commented on pull request #78: PHOENIX-6694 Share the query plan generated in data source reader in …
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #78:
URL: https://github.com/apache/phoenix-connectors/pull/78#issuecomment-1109490466
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 33s | master passed |
| +1 :green_heart: | compile | 1m 42s | master passed |
| +1 :green_heart: | checkstyle | 0m 16s | master passed |
| +1 :green_heart: | javadoc | 0m 23s | master passed |
| +0 :ok: | spotbugs | 2m 51s | phoenix-spark-base in master has 40 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 21m 10s | the patch passed |
| +1 :green_heart: | compile | 1m 47s | the patch passed |
| +1 :green_heart: | javac | 1m 47s | the patch passed |
| -1 :x: | checkstyle | 0m 18s | phoenix-spark-base: The patch generated 17 new + 127 unchanged - 10 fixed = 144 total (was 137) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 23s | the patch passed |
| -1 :x: | spotbugs | 2m 35s | phoenix-spark-base generated 1 new + 38 unchanged - 2 fixed = 39 total (was 40) |
||| _ Other Tests _ |
| -1 :x: | unit | 5m 17s | phoenix-spark-base in the patch failed. |
| -1 :x: | asflicense | 0m 15s | The patch generated 2 ASF License warnings. |
| | | 77m 43s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-spark-base |
| | Class org.apache.phoenix.spark.datasource.v2.reader.PhoenixDataSourceReadOptions defines non-transient non-serializable instance field queryPlan In PhoenixDataSourceReadOptions.java:instance field queryPlan In PhoenixDataSourceReadOptions.java |
| Failed junit tests | phoenix.spark.SaltedTableIT |
| | phoenix.spark.OrderByIT |
| | phoenix.spark.AggregateIT |
| | phoenix.spark.SaltedTableIT |
| | phoenix.spark.OrderByIT |
| | phoenix.spark.AggregateIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/78 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux fa9db5b2156a 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 9ed127f |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-spark-base.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-spark-base.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/artifact/yetus-general-check/output/patch-unit-phoenix-spark-base.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 1466 (vs. ulimit of 30000) |
| modules | C: phoenix-spark-base U: phoenix-spark-base |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-78/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] chrajeshbabu commented on pull request #78: PHOENIX-6694 Share the query plan generated in data source reader in …
Posted by GitBox <gi...@apache.org>.
chrajeshbabu commented on PR #78:
URL: https://github.com/apache/phoenix-connectors/pull/78#issuecomment-1122611582
Closing this PR which will not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-connectors] chrajeshbabu closed pull request #78: PHOENIX-6694 Share the query plan generated in data source reader in …
Posted by GitBox <gi...@apache.org>.
chrajeshbabu closed pull request #78: PHOENIX-6694 Share the query plan generated in data source reader in …
URL: https://github.com/apache/phoenix-connectors/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org