[jira] [Commented] (YARN-695) masterContainer and status are in ApplicationReportProto but not in ApplicationReport

["Zhijie Shen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660920#comment-13660920 ] 

Zhijie Shen commented on YARN-695:
----------------------------------

Status has been used in ApplicationReportPBImpl, but the code looks buggy. The following two setters both check applicationId and clear status.

{code}
  @Override
  public void setApplicationId(ApplicationId applicationId) {
    maybeInitBuilder();
    if (applicationId == null)
      builder.clearStatus();
    this.applicationId = applicationId;
  }

  @Override
  public void setCurrentApplicationAttemptId(ApplicationAttemptId applicationAttemptId) {
    maybeInitBuilder();
    if (applicationId == null)
      builder.clearStatus();
    this.currentApplicationAttemptId = applicationAttemptId;
  }
{code}
                
> masterContainer and status are in ApplicationReportProto but not in ApplicationReport
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-695
>                 URL: https://issues.apache.org/jira/browse/YARN-695
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>
> If masterContainer and status are no longer part of ApplicationReport, they should be removed from proto as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira