[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #403: [FLINK-30205] Modify compact interface for TableWrite and FileStoreWrite to support normal compaction in Table Store

[GitBox <gi...@apache.org>]

tsreaper commented on code in PR #403:
URL: https://github.com/apache/flink-table-store/pull/403#discussion_r1033078213


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RecordWriter.java:
##########
@@ -34,10 +34,12 @@
     void write(T record) throws Exception;
 
     /**
-     * Compact all files related to the writer. Note that compaction process is only submitted and
-     * may not be completed when the method returns.
+     * Compact files related to the writer. Note that compaction process is only submitted and may
+     * not be completed when the method returns.
+     *
+     * @param fullCompaction whether to trigger full compaction or just normal compaction

Review Comment:
   From the point of a separated compact job, we should always wait for last compaction to complete. Otherwise new changes may never be compacted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org