You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/11/17 16:39:21 UTC
DO NOT REPLY [Bug 50286] New: URLRewritingModifier : extracted
jsessionid value is incorrect
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
Summary: URLRewritingModifier : extracted jsessionid value is
incorrect
Product: JMeter
Version: 2.4
Platform: All
OS/Version: All
Status: NEW
Severity: major
Priority: P2
Component: HTTP
AssignedTo: notifications@jakarta.apache.org
ReportedBy: gregory.lardiere@maaf.fr
When extracted from an XML document, the jsessionid value might contains extra
characters. For example, with this XML :
"<url>/some/path;jsessionid=123456789</url>", the extracted jsessionid is
"123456789</url".
The attached patch fixes the problem by excluding the "<" character from the
list of allowed characters for a jsessionid value.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
--- Comment #4 from Sebb <se...@apache.org> 2010-11-20 15:34:14 EST ---
(In reply to comment #3)
> Not sure how that could be using that for the example you gave.
Scrub that sentence - does not apply.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #8 from Sebb <se...@apache.org> 2010-11-22 06:45:56 EST ---
Thanks for confirming your settings.
Code has now also been fixed for the PathExtension=false case.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #3 from Sebb <se...@apache.org> 2010-11-20 12:56:01 EST ---
I'm not sure this is fully solved. At least there needs to be a test case.
So I wrote a test case - but it failed because it does not use any of the REs
that have been patched. Instead it uses parameterRegexp.
@Gregory: Does your test use Path Extension = true?
Not sure how that could be using that for the example you gave.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
--- Comment #6 from Gregory Lardiere <gr...@maaf.fr> 2010-11-22 04:42:58 EST ---
(In reply to comment #3)
> @Gregory: Does your test use Path Extension = true?
yes, my test uses PathExtension=true and PathExtensionNoQuestionmark=true
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
--- Comment #5 from Milamber <mi...@apache.org> 2010-11-20 16:32:57 EST ---
The solve wouldn't be adding a < in parameterRegexp?
parameterRegexp = JMeterUtils.getPatternCache().getPattern(
// ;sessionid=value
"[;\\?&]" + quotedArg + "=([^\"'>&\\s;\\\\]*)" + //
$NON-NLS-1$
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URLRewritingModifier : extracted jsessionid
value is incorrect
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
--- Comment #1 from Gregory Lardiere <gr...@maaf.fr> 2010-11-17 10:41:06 EST ---
Created an attachment (id=26305)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26305)
Patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
--- Comment #7 from Gregory Lardiere <gr...@maaf.fr> 2010-11-22 04:51:06 EST ---
(In reply to comment #5)
> The solve wouldn't be adding a < in parameterRegexp?
My patch solves the problem in my case (PathExtension=true).
The same problem may exists as well in the "PathExtension=false" case, I didn't
checked.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
Milamber <mi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Milamber <mi...@apache.org> 2010-11-19 16:08:52 EST ---
Thanks for report and patch. Done in SVN
URL: http://svn.apache.org/viewvc?rev=1037021&view=rev
Log:
Bug 50286 - URL Re-writing Modifier: extracted jsessionid value is incorrect
when is between XML tags
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/URLRewritingModifier.java
jakarta/jmeter/trunk/xdocs/changes.xml
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50286] URL Re-writing Modifier: extracted
jsessionid value is incorrect when is between XML tags
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50286
Milamber <mi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|URLRewritingModifier : |URL Re-writing Modifier:
|extracted jsessionid value |extracted jsessionid value
|is incorrect |is incorrect when is
| |between XML tags
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org