You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/05 21:43:18 UTC
[GitHub] [geode] rhoughton-pivot opened a new pull request #5057: GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT.
rhoughton-pivot opened a new pull request #5057:
URL: https://github.com/apache/geode/pull/5057
* Artifacts take the form `1.13.0-build.123` instead of `1.13.0-SNAPSHOT`.
* checkPom task has been modified to use a slug instead of an always
changing version.
* Gradle clients will use the greedy "1.13.0-build+" notation
* Maven clients will use semver v1.0 "[1.13.0-build,1.14.0)" notation.
Signed-off-by: Robert Houghton <rh...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5057: GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #5057:
URL: https://github.com/apache/geode/pull/5057#discussion_r421689722
##########
File path: ci/scripts/shared_utilities.sh
##########
@@ -31,7 +31,7 @@ find-here-test-reports() {
}
## Parsing functions for the Concourse Semver resource.
-## These functions expect one input in the form of the resource file, e.g., "1.9.0-SNAPSHOT.325"
+## These functions expect one input in the form of the resource file, e.g., "1.9.0-build.325"
Review comment:
Yes. I'll change it during the rebase (rebasing due to conflict).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dickcav commented on a change in pull request #5057: GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT.
Posted by GitBox <gi...@apache.org>.
dickcav commented on a change in pull request #5057:
URL: https://github.com/apache/geode/pull/5057#discussion_r420470789
##########
File path: gradle.properties
##########
@@ -22,13 +22,11 @@
# The releaseQualifier uses the following conventions:
Review comment:
We don't use these other releaseQualifiers so can we remove them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dickcav commented on a change in pull request #5057: GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT.
Posted by GitBox <gi...@apache.org>.
dickcav commented on a change in pull request #5057:
URL: https://github.com/apache/geode/pull/5057#discussion_r420470363
##########
File path: ci/scripts/shared_utilities.sh
##########
@@ -31,7 +31,7 @@ find-here-test-reports() {
}
## Parsing functions for the Concourse Semver resource.
-## These functions expect one input in the form of the resource file, e.g., "1.9.0-SNAPSHOT.325"
+## These functions expect one input in the form of the resource file, e.g., "1.9.0-build.325"
Review comment:
Can we use 1.14.0 here instead of an old version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5057: GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5057:
URL: https://github.com/apache/geode/pull/5057#discussion_r420478753
##########
File path: ci/scripts/execute_build_examples.sh
##########
@@ -17,7 +17,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-set -e
+set -ex
Review comment:
just to confirm, was this change intended, or "debugging" that accidentally got left in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5057: GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #5057:
URL: https://github.com/apache/geode/pull/5057#discussion_r421690114
##########
File path: gradle.properties
##########
@@ -22,13 +22,11 @@
# The releaseQualifier uses the following conventions:
Review comment:
Can, but I'm not ready to as part of this change.
##########
File path: ci/scripts/execute_build_examples.sh
##########
@@ -17,7 +17,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-set -e
+set -ex
Review comment:
It was, and leaks no secrets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org