You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "LiShiZhensPi (via GitHub)" <gi...@apache.org> on 2023/02/13 15:01:27 UTC
[GitHub] [arrow-rs] LiShiZhensPi opened a new pull request, #3711: Feat/arrow csv decimal256
LiShiZhensPi opened a new pull request, #3711:
URL: https://github.com/apache/arrow-rs/pull/3711
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3474
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
arrow-csv only seems to support decimal128
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
now the arrow-csv can support decimal256
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] LiShiZhensPi commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "LiShiZhensPi (via GitHub)" <gi...@apache.org>.
LiShiZhensPi commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1106001721
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -233,7 +233,8 @@ pub type Decimal256Array = PrimitiveArray<Decimal256Type>;
/// static-typed nature of rust types ([`ArrowNativeType`]) for all types that implement [`ArrowNativeType`].
pub trait ArrowPrimitiveType: 'static {
/// Corresponding Rust native type for the primitive type.
- type Native: ArrowNativeType;
+ // FIXME: this may affect other code, is this correct?
+ type Native: ArrowNativeType + ArrowNativeTypeOp;
Review Comment:
yes, It is indeed better to write this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1105625484
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -880,6 +919,77 @@ fn parse_decimal_with_parameter(
}
}
+// Parse the string format decimal value to i256 format and checking the precision and scale.
+// The result i256 value can't be out of bounds.
+fn parse_decimal256_with_parameter(
+ s: &str,
+ precision: u8,
+ scale: i8,
+) -> Result<i256, ArrowError> {
+ if PARSE_DECIMAL_RE.is_match(s) {
+ let mut offset = s.len();
+ let len = s.len();
+ let mut base = i256::from_i128(1);
+ let scale_usize = usize::from(scale as u8);
+
+ // handle the value after the '.' and meet the scale
+ let delimiter_position = s.find('.');
+ match delimiter_position {
+ None => {
+ // there is no '.'
+ // FIXME: Is it appropriate to write like this?
Review Comment:
```suggestion
```
Looks correct to me
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -814,6 +818,41 @@ fn build_decimal_array(
))
}
+//TODO: is possible to use generic function replace this?
Review Comment:
It should be possible to write a function generic over `T: DecimalType`
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -880,6 +919,77 @@ fn parse_decimal_with_parameter(
}
}
+// Parse the string format decimal value to i256 format and checking the precision and scale.
+// The result i256 value can't be out of bounds.
+fn parse_decimal256_with_parameter(
+ s: &str,
+ precision: u8,
+ scale: i8,
+) -> Result<i256, ArrowError> {
+ if PARSE_DECIMAL_RE.is_match(s) {
+ let mut offset = s.len();
+ let len = s.len();
+ let mut base = i256::from_i128(1);
+ let scale_usize = usize::from(scale as u8);
+
+ // handle the value after the '.' and meet the scale
+ let delimiter_position = s.find('.');
+ match delimiter_position {
+ None => {
+ // there is no '.'
+ // FIXME: Is it appropriate to write like this?
+ base = i256::from_i128(10).wrapping_pow(scale as u32);
+ }
+ Some(mid) => {
+ // there is the '.'
+ if len - mid >= scale_usize + 1 {
+ // If the string value is "123.12345" and the scale is 2, we should just remain '.12' and drop the '345' value.
+ offset -= len - mid - 1 - scale_usize;
+ } else {
+ // If the string value is "123.12" and the scale is 4, we should append '00' to the tail.
+ base = i256::from_i128(10)
+ .wrapping_pow((scale_usize + 1 + mid - len) as u32);
+ }
+ }
+ };
+
+ // each byte is digit、'-' or '.'
+ let bytes = s.as_bytes();
+ let mut negative = false;
+ let mut result = i256::from_i128(0);
+
+ bytes[0..offset].iter().rev().for_each(|&byte| match byte {
+ b'-' => {
+ negative = true;
+ }
+ b'0'..=b'9' => {
+ //TODO: support '+=' and '*=' for i256
+ //TODO: support i256::from_byte for i256
Review Comment:
Given these don't impact the correctness of the code, I'd suggest leaving these out and perhaps filing a ticket to add support for these?
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -880,6 +919,77 @@ fn parse_decimal_with_parameter(
}
}
+// Parse the string format decimal value to i256 format and checking the precision and scale.
+// The result i256 value can't be out of bounds.
+fn parse_decimal256_with_parameter(
+ s: &str,
+ precision: u8,
+ scale: i8,
+) -> Result<i256, ArrowError> {
+ if PARSE_DECIMAL_RE.is_match(s) {
+ let mut offset = s.len();
+ let len = s.len();
+ let mut base = i256::from_i128(1);
+ let scale_usize = usize::from(scale as u8);
+
+ // handle the value after the '.' and meet the scale
+ let delimiter_position = s.find('.');
+ match delimiter_position {
+ None => {
+ // there is no '.'
+ // FIXME: Is it appropriate to write like this?
+ base = i256::from_i128(10).wrapping_pow(scale as u32);
+ }
+ Some(mid) => {
+ // there is the '.'
+ if len - mid >= scale_usize + 1 {
+ // If the string value is "123.12345" and the scale is 2, we should just remain '.12' and drop the '345' value.
+ offset -= len - mid - 1 - scale_usize;
+ } else {
+ // If the string value is "123.12" and the scale is 4, we should append '00' to the tail.
+ base = i256::from_i128(10)
+ .wrapping_pow((scale_usize + 1 + mid - len) as u32);
+ }
+ }
+ };
+
+ // each byte is digit、'-' or '.'
+ let bytes = s.as_bytes();
+ let mut negative = false;
+ let mut result = i256::from_i128(0);
+
+ bytes[0..offset].iter().rev().for_each(|&byte| match byte {
+ b'-' => {
+ negative = true;
+ }
+ b'0'..=b'9' => {
+ //TODO: support '+=' and '*=' for i256
+ //TODO: support i256::from_byte for i256
Review Comment:
```suggestion
```
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -880,6 +919,77 @@ fn parse_decimal_with_parameter(
}
}
+// Parse the string format decimal value to i256 format and checking the precision and scale.
+// The result i256 value can't be out of bounds.
+fn parse_decimal256_with_parameter(
+ s: &str,
+ precision: u8,
+ scale: i8,
+) -> Result<i256, ArrowError> {
+ if PARSE_DECIMAL_RE.is_match(s) {
+ let mut offset = s.len();
+ let len = s.len();
+ let mut base = i256::from_i128(1);
+ let scale_usize = usize::from(scale as u8);
+
+ // handle the value after the '.' and meet the scale
+ let delimiter_position = s.find('.');
+ match delimiter_position {
+ None => {
+ // there is no '.'
+ // FIXME: Is it appropriate to write like this?
+ base = i256::from_i128(10).wrapping_pow(scale as u32);
+ }
+ Some(mid) => {
+ // there is the '.'
+ if len - mid >= scale_usize + 1 {
+ // If the string value is "123.12345" and the scale is 2, we should just remain '.12' and drop the '345' value.
+ offset -= len - mid - 1 - scale_usize;
+ } else {
+ // If the string value is "123.12" and the scale is 4, we should append '00' to the tail.
+ base = i256::from_i128(10)
+ .wrapping_pow((scale_usize + 1 + mid - len) as u32);
+ }
+ }
+ };
+
+ // each byte is digit、'-' or '.'
+ let bytes = s.as_bytes();
+ let mut negative = false;
+ let mut result = i256::from_i128(0);
+
+ bytes[0..offset].iter().rev().for_each(|&byte| match byte {
+ b'-' => {
+ negative = true;
+ }
+ b'0'..=b'9' => {
+ //TODO: support '+=' and '*=' for i256
+ //TODO: support i256::from_byte for i256
+ result = result + i256::from_i128((byte - b'0').into()) * base;
+ //TODO: support Mul<i32> for i256
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] LiShiZhensPi commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "LiShiZhensPi (via GitHub)" <gi...@apache.org>.
LiShiZhensPi commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1106066989
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -1318,7 +1339,7 @@ mod tests {
let schema = Schema::new(vec![
Field::new("city", DataType::Utf8, false),
Field::new("lat", DataType::Decimal128(38, 6), false),
- Field::new("lng", DataType::Decimal128(38, 6), false),
+ Field::new("lng", DataType::Decimal256(38, 6), false),
Review Comment:
yes, I found the `DECIMAL256_MAX_PRECISION` is 76, so maybe change it to `Decimal256(76, 6)` is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3711: Feat: arrow csv decimal256
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#issuecomment-1430253605
Thank you. This looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3711: Feat: arrow csv decimal256
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#issuecomment-1430477398
Thank you again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] LiShiZhensPi commented on pull request #3711: Feat/arrow csv decimal256
Posted by "LiShiZhensPi (via GitHub)" <gi...@apache.org>.
LiShiZhensPi commented on PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#issuecomment-1429972988
now the function return error instead of panic🤓
https://github.com/apache/arrow-rs/pull/3711#pullrequestreview-1297811625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1106048286
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -1318,7 +1339,7 @@ mod tests {
let schema = Schema::new(vec![
Field::new("city", DataType::Utf8, false),
Field::new("lat", DataType::Decimal128(38, 6), false),
- Field::new("lng", DataType::Decimal128(38, 6), false),
+ Field::new("lng", DataType::Decimal256(38, 6), false),
Review Comment:
Maybe use a larger precision/scale for `Decimal256`.
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -1788,20 +1826,20 @@ mod tests {
("-123.", -123000i128),
];
for (s, i) in tests {
- let result = parse_decimal_with_parameter(s, 20, 3);
+ let result = parse_decimal_with_parameter::<Decimal128Type>(s, 20, 3);
assert_eq!(i, result.unwrap())
}
let can_not_parse_tests = ["123,123", ".", "123.123.123"];
for s in can_not_parse_tests {
- let result = parse_decimal_with_parameter(s, 20, 3);
+ let result = parse_decimal_with_parameter::<Decimal128Type>(s, 20, 3);
assert_eq!(
format!("Parser error: can't parse the string value {s} to decimal"),
result.unwrap_err().to_string()
);
}
let overflow_parse_tests = ["12345678", "12345678.9", "99999999.99"];
for s in overflow_parse_tests {
- let result = parse_decimal_with_parameter(s, 10, 3);
+ let result = parse_decimal_with_parameter::<Decimal128Type>(s, 10, 3);
Review Comment:
Perhaps adding test for `Decimal256Type`.
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -781,22 +795,22 @@ fn parse_bool(string: &str) -> Option<bool> {
}
// parse the column string to an Arrow Array
-fn build_decimal_array(
+fn build_decimal_array<T: DecimalType>(
Review Comment:
👍
##########
arrow-csv/src/writer.rs:
##########
@@ -406,6 +408,59 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.555000000,23:46:03,foo
assert_eq!(expected.to_string(), String::from_utf8(buffer).unwrap());
}
+ #[test]
+ fn test_write_csv_decimal() {
+ let schema = Schema::new(vec![
+ Field::new("c1", DataType::Decimal128(38, 6), true),
+ Field::new("c2", DataType::Decimal256(38, 6), true),
Review Comment:
ditto. Maybe using larger precision/scale for Decimal256.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1106083206
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -1318,7 +1339,7 @@ mod tests {
let schema = Schema::new(vec![
Field::new("city", DataType::Utf8, false),
Field::new("lat", DataType::Decimal128(38, 6), false),
- Field::new("lng", DataType::Decimal128(38, 6), false),
+ Field::new("lng", DataType::Decimal256(38, 6), false),
Review Comment:
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1105960718
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -233,7 +233,8 @@ pub type Decimal256Array = PrimitiveArray<Decimal256Type>;
/// static-typed nature of rust types ([`ArrowNativeType`]) for all types that implement [`ArrowNativeType`].
pub trait ArrowPrimitiveType: 'static {
/// Corresponding Rust native type for the primitive type.
- type Native: ArrowNativeType;
+ // FIXME: this may affect other code, is this correct?
+ type Native: ArrowNativeType + ArrowNativeTypeOp;
Review Comment:
```suggestion
type Native: ArrowNativeTypeOp;
```
`ArrowNativeType` is implied by `ArrowNativeTypeOp`.
I think this change is fine, but tagging @viirya who added `ArrowNativeTypeOp` originally.
This will allow simplifying trait bounds in a number of other places, where we currently have to add a `T::Native: ArrowNativeTypeOp` constraint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1105960718
##########
arrow-array/src/array/primitive_array.rs:
##########
@@ -233,7 +233,8 @@ pub type Decimal256Array = PrimitiveArray<Decimal256Type>;
/// static-typed nature of rust types ([`ArrowNativeType`]) for all types that implement [`ArrowNativeType`].
pub trait ArrowPrimitiveType: 'static {
/// Corresponding Rust native type for the primitive type.
- type Native: ArrowNativeType;
+ // FIXME: this may affect other code, is this correct?
+ type Native: ArrowNativeType + ArrowNativeTypeOp;
Review Comment:
```suggestion
type Native: ArrowNativeTypeOp;
```
`ArrowNativeType` is implied by `ArrowNativeTypeOp`.
I think this change is fine, but tagging @viirya who added `ArrowNativeTypeOp` originally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3711: Feat: arrow csv decimal256
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] LiShiZhensPi commented on a diff in pull request #3711: Feat/arrow csv decimal256
Posted by "LiShiZhensPi (via GitHub)" <gi...@apache.org>.
LiShiZhensPi commented on code in PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#discussion_r1105716244
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -814,6 +818,41 @@ fn build_decimal_array(
))
}
+//TODO: is possible to use generic function replace this?
Review Comment:
Thanks for your help, I'll fix these soon🌝
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] LiShiZhensPi commented on pull request #3711: Feat/arrow csv decimal256
Posted by "LiShiZhensPi (via GitHub)" <gi...@apache.org>.
LiShiZhensPi commented on PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#issuecomment-1429899480
To support operations `ArrowNativeTypeOp` in generic functions, I change the code to `type Native: ArrowNativeType + ArrowNativeTypeOp` in privimitive_array.rs. I'm not sure if this is correct. Pay attention to this when reviewing the code🤓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3711: Feat: arrow csv decimal256
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3711:
URL: https://github.com/apache/arrow-rs/pull/3711#issuecomment-1430487729
Benchmark runs are scheduled for baseline = d74051061a8be0d06b8112901d19d748c7ac0d9f and contender = 22c138156715bf62c8c683fb94e947f7a3200149. 22c138156715bf62c8c683fb94e947f7a3200149 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7e8c926de035445fb585194641cc5157...70e83d60290f4d878d28ea2c5f830fcf/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/10b30fc2b84f41a59daa80b50d1d08dc...d41605941bd34acd836dc596fadc209e/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7ee9d30524c94f0eac9c97b92edc1c3e...deccfbd8ad964e32b6d9ae08a48a01c2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cea4572c6204447f9fb6d6b71963bbe8...e41c7beb39654b1da970c5315a3e5d50/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org