You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2020/10/19 03:44:45 UTC
[shardingsphere-elasticjob] branch master updated: Remove real
token from error handler test cases (#1590)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git
The following commit(s) were added to refs/heads/master by this push:
new ce38173 Remove real token from error handler test cases (#1590)
ce38173 is described below
commit ce3817397aa1f2e6e23ea761e778a9e0607c9347
Author: Yanjie Zhou <zh...@aliyun.com>
AuthorDate: Mon Oct 19 11:44:37 2020 +0800
Remove real token from error handler test cases (#1590)
---
.../error/handler/dingtalk/DingtalkJobErrorHandlerTest.java | 12 ++++++------
.../handler/dingtalk/fixture/DingtalkInternalController.java | 6 +++---
.../error/handler/wechat/WechatJobErrorHandlerTest.java | 4 ++--
.../handler/wechat/fixture/WechatInternalController.java | 2 +-
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkJobErrorHandlerTest.java b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkJobErrorHandlerTest.java
index 0ca80ce..3313e15 100644
--- a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkJobErrorHandlerTest.java
+++ b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/DingtalkJobErrorHandlerTest.java
@@ -72,7 +72,7 @@ public final class DingtalkJobErrorHandlerTest {
DingtalkJobErrorHandler actual = getDingtalkJobErrorHandler();
setStaticFieldValue(actual);
Throwable cause = new RuntimeException("test");
- actual.handleException("test_job", createJobProperties("http://localhost:9875/send?access_token=42eead064e81ce81fc6af2c107fbe10a4339a3d40a7db8abf5b34d8261527a3f"), cause);
+ actual.handleException("test_job", createJobProperties("http://localhost:9875/send?access_token=mocked_token"), cause);
verify(log).info("An exception has occurred in Job '{}', Notification to Dingtalk was successful.", "test_job", cause);
}
@@ -81,7 +81,7 @@ public final class DingtalkJobErrorHandlerTest {
DingtalkJobErrorHandler actual = getDingtalkJobErrorHandler();
setStaticFieldValue(actual);
Throwable cause = new RuntimeException("test");
- actual.handleException("test_job", createJobProperties("http://localhost:9875/send?access_token=wrongToken"), cause);
+ actual.handleException("test_job", createJobProperties("http://localhost:9875/send?access_token=wrong_token"), cause);
verify(log).info("An exception has occurred in Job '{}', But failed to send alert by Dingtalk because of: {}", "test_job", "token is not exist", cause);
}
@@ -108,7 +108,7 @@ public final class DingtalkJobErrorHandlerTest {
DingtalkJobErrorHandler actual = getDingtalkJobErrorHandler();
setStaticFieldValue(actual);
Throwable cause = new RuntimeException("test");
- actual.handleException("test_job", createNoSignJobProperties("http://localhost:9875/send?access_token=42eead064e81ce81fc6af2c107fbe10a4339a3d40a7db8abf5b34d8261527a3f"), cause);
+ actual.handleException("test_job", createNoSignJobProperties("http://localhost:9875/send?access_token=mocked_token"), cause);
verify(log).info("An exception has occurred in Job '{}', Notification to Dingtalk was successful.", "test_job", cause);
}
@@ -129,8 +129,8 @@ public final class DingtalkJobErrorHandlerTest {
private Properties createJobProperties(final String webhook) {
Properties result = new Properties();
result.setProperty(DingtalkPropertiesConstants.WEBHOOK, webhook);
- result.setProperty(DingtalkPropertiesConstants.KEYWORD, "keyword");
- result.setProperty(DingtalkPropertiesConstants.SECRET, "SEC0b0a6b13b6823b95737dd83491c23adee5d8a7a649899a12217e038eddc84ff4");
+ result.setProperty(DingtalkPropertiesConstants.KEYWORD, "mocked_keyword");
+ result.setProperty(DingtalkPropertiesConstants.SECRET, "mocked_secret");
result.setProperty(DingtalkPropertiesConstants.CONNECT_TIMEOUT_MILLISECOND, "4000");
result.setProperty(DingtalkPropertiesConstants.READ_TIMEOUT_MILLISECOND, "6000");
return result;
@@ -139,7 +139,7 @@ public final class DingtalkJobErrorHandlerTest {
private Properties createNoSignJobProperties(final String webhook) {
Properties result = new Properties();
result.setProperty(DingtalkPropertiesConstants.WEBHOOK, webhook);
- result.setProperty(DingtalkPropertiesConstants.KEYWORD, "keyword");
+ result.setProperty(DingtalkPropertiesConstants.KEYWORD, "mocked_keyword");
result.setProperty(DingtalkPropertiesConstants.CONNECT_TIMEOUT_MILLISECOND, "4000");
result.setProperty(DingtalkPropertiesConstants.READ_TIMEOUT_MILLISECOND, "6000");
return result;
diff --git a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/fixture/DingtalkInternalController.java b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/fixture/DingtalkInternalController.java
index eb5d01e..1dd005b 100644
--- a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/fixture/DingtalkInternalController.java
+++ b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-dingtalk/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/dingtalk/fixture/DingtalkInternalController.java
@@ -40,11 +40,11 @@ import java.util.Map;
public final class DingtalkInternalController implements RestfulController {
- private static final String ACCESS_TOKEN = "42eead064e81ce81fc6af2c107fbe10a4339a3d40a7db8abf5b34d8261527a3f";
+ private static final String ACCESS_TOKEN = "mocked_token";
- private static final String KEYWORD = "keyword";
+ private static final String KEYWORD = "mocked_keyword";
- private static final String SECRET = "SEC0b0a6b13b6823b95737dd83491c23adee5d8a7a649899a12217e038eddc84ff4";
+ private static final String SECRET = "mocked_secret";
/**
* Send Dingtalk message.
diff --git a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatJobErrorHandlerTest.java b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatJobErrorHandlerTest.java
index 3098a74..3b071fc 100644
--- a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatJobErrorHandlerTest.java
+++ b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/WechatJobErrorHandlerTest.java
@@ -72,7 +72,7 @@ public final class WechatJobErrorHandlerTest {
WechatJobErrorHandler actual = getWechatJobErrorHandler();
setStaticFieldValue(actual);
Throwable cause = new RuntimeException("test");
- actual.handleException("test_job", getJobProperties("http://localhost:9872/send?key=TLQEC0cPivqV1MkT0IPMtzunTBBVyIV3"), cause);
+ actual.handleException("test_job", getJobProperties("http://localhost:9872/send?key=mocked_key"), cause);
verify(log).info("An exception has occurred in Job '{}', Notification to wechat was successful.", "test_job", cause);
}
@@ -81,7 +81,7 @@ public final class WechatJobErrorHandlerTest {
WechatJobErrorHandler actual = getWechatJobErrorHandler();
setStaticFieldValue(actual);
Throwable cause = new RuntimeException("test");
- actual.handleException("test_job", getJobProperties("http://localhost:9872/send?key=wrongToken"), cause);
+ actual.handleException("test_job", getJobProperties("http://localhost:9872/send?key=wrong_key"), cause);
verify(log).info("An exception has occurred in Job '{}', But failed to send alert by wechat because of: {}", "test_job", "token is invalid", cause);
}
diff --git a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/fixture/WechatInternalController.java b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/fixture/WechatInternalController.java
index 60df88f..4acf631 100644
--- a/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/fixture/WechatInternalController.java
+++ b/elasticjob-error-handler/elasticjob-error-handler-type/elasticjob-error-handler-wechat/src/test/java/org/apache/shardingsphere/elasticjob/error/handler/wechat/fixture/WechatInternalController.java
@@ -28,7 +28,7 @@ import org.apache.shardingsphere.elasticjob.restful.annotation.ParamSource;
public final class WechatInternalController implements RestfulController {
- private static final String KEY = "TLQEC0cPivqV1MkT0IPMtzunTBBVyIV3";
+ private static final String KEY = "mocked_key";
/**
* Send wechat message.