You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/11/15 23:15:46 UTC

[kudu-CR] [fs] simplify FsErrorManager

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22074


Change subject: [fs] simplify FsErrorManager
......................................................................

[fs] simplify FsErrorManager

This patch updates the code in FsErrorManager to use
  * std::array instead of std::unordered_map
  * std::mutex instead of Mutex

Otherwise, this patch doesn't contain any functional modifications.

Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
---
M src/kudu/fs/error_manager.cc
M src/kudu/fs/error_manager.h
2 files changed, 23 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22074/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 06:36:20 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/682/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 16 Nov 2024 11:15:54 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/686/


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 02:14:26 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22074

to look at the new patch set (#3).

Change subject: [fs] simplify FsErrorManager
......................................................................

[fs] simplify FsErrorManager

This patch updates the code in FsErrorManager to use
  * std::array instead of std::unordered_map
  * std::mutex instead of Mutex

Also, {Master,TabletServer}::ShutdownImpl() now unregister all the error
handlers that have been registered.

Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
---
M src/kudu/fs/error_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/master/master.cc
M src/kudu/tserver/tablet_server.cc
4 files changed, 32 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22074/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 2: Verified+1

> Thanks a lot for review!
 > 
 > It seems something is screwed up in the lifecycle of FsErrorManager
 > objects (at least for several tests), where the usual suspect is
 > bee1283718fda9d9d28455e62501e52f78fbf565.  That's became apparent
 > once replacing Mutex with std::mutex as a member of FsErrorManager.
 > 
 > I need to clarify on this and post a fix.

Ah, I take that back.

It turned out the problem was just off-by-one mistake on my own.  This is now fixed in PS2.


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 02:15:26 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 3: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/687/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 03:46:42 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 3: Code-Review+2

> Patch Set 2: Verified+1
> 
> > Thanks a lot for review!
>  > 
>  > It seems something is screwed up in the lifecycle of FsErrorManager
>  > objects (at least for several tests), where the usual suspect is
>  > bee1283718fda9d9d28455e62501e52f78fbf565.  That's became apparent
>  > once replacing Mutex with std::mutex as a member of FsErrorManager.
>  > 
>  > I need to clarify on this and post a fix.
> 
> Ah, I take that back.
> 
> It turned out the problem was just off-by-one mistake on my own.  This is now fixed in PS2.

Thanks for fixing it. The latest patch set looks good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 04:01:16 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 2:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/686/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 02:20:47 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/687/


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 19 Nov 2024 02:20:51 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................

[fs] simplify FsErrorManager

This patch updates the code in FsErrorManager to use
  * std::array instead of std::unordered_map
  * std::mutex instead of Mutex

Also, {Master,TabletServer}::ShutdownImpl() now unregister all the error
handlers that have been registered.

Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Reviewed-on: http://gerrit.cloudera.org:8080/22074
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/fs/error_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/master/master.cc
M src/kudu/tserver/tablet_server.cc
4 files changed, 32 insertions(+), 25 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yifan Zhang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22074

to look at the new patch set (#2).

Change subject: [fs] simplify FsErrorManager
......................................................................

[fs] simplify FsErrorManager

This patch updates the code in FsErrorManager to use
  * std::array instead of std::unordered_map
  * std::mutex instead of Mutex

Otherwise, this patch doesn't contain any functional modifications.

Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
---
M src/kudu/fs/error_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/master/master.cc
M src/kudu/tserver/tablet_server.cc
4 files changed, 32 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/22074/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/682/


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 Nov 2024 23:15:52 +0000
Gerrit-HasComments: No

[kudu-CR] [fs] simplify FsErrorManager

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )

Change subject: [fs] simplify FsErrorManager
......................................................................


Patch Set 1: Verified-1

Thanks a lot for review!

It seems something is screwed up in the lifecycle of FsErrorManager objects (at least for several tests), where the usual suspect is bee1283718fda9d9d28455e62501e52f78fbf565.  That's became apparent once replacing Mutex with std::mutex as a member of FsErrorManager.

I need to clarify on this and post a fix.


-- 
To view, visit http://gerrit.cloudera.org:8080/22074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434
Gerrit-Change-Number: 22074
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 23:01:14 +0000
Gerrit-HasComments: No